Skip to content

U-Boot: refactor general info for the AM62Lx boot flow#204

Merged
praneethbajjuri merged 3 commits intoTexasInstruments:masterfrom
bryanbrattlof:am62lx-uboot
Mar 19, 2025
Merged

U-Boot: refactor general info for the AM62Lx boot flow#204
praneethbajjuri merged 3 commits intoTexasInstruments:masterfrom
bryanbrattlof:am62lx-uboot

Conversation

@bryanbrattlof
Copy link
Copy Markdown
Collaborator

@bryanbrattlof bryanbrattlof commented Mar 5, 2025

Quite a lot has changed for the AM62Lx boot flow when compared to more traditional AM62 devices. After hiding un-necessary sections document via ASCII charts the bootflow between the SMS and A53 cores along with the memory layout of the 2 SRAM spaces during the boot sequence

Unfortunately this will create a lot of warnings about undefined references to optee. Other than creating an entirely new U-Boot file for 62L I don't think we can get rid of them now. One idea is to add optee back in with a simple landing page saying something along the lines of raise NotImplementedError() or something

cshilwant
cshilwant requested changes Mar 5, 2025
View reviewed changes
cshilwant
cshilwant requested changes Mar 5, 2025
View reviewed changes
source/linux/Foundational_Components/U-Boot/UG-General-Info.rst
Copy link
Copy Markdown
Member

@cshilwant cshilwant Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation for all your newly added table got messed up in v2

Checkout RST preview - https://github.com/TexasInstruments/processor-sdk-doc/blob/3e559df08028e91d1fa0947828279fe416fe3688/source/linux/Foundational_Components/U-Boot/UG-General-Info.rst

Copy link
Copy Markdown
Collaborator Author

@bryanbrattlof bryanbrattlof Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah a plugin was trying to be helpful :/ I fixed it now.

Copy link
Copy Markdown
Member

@cshilwant cshilwant Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/TexasInstruments/processor-sdk-doc/blob/5a75128e8c1127480e13dab183780b39d7af2ee0/source/linux/Foundational_Components/U-Boot/UG-General-Info.rst

@bryanbrattlof The indentation for all your newly added table still seems to be incorrect

Copy link
Copy Markdown
Collaborator Author

@bryanbrattlof bryanbrattlof Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'm don't think I see the issue you're seeing. I'm assuming your talking about the boot flow diagrams which I had a little trouble myself so I just disabled the bootflow section on line 1324 if we're rendering for the AM62L and made a complete new section below that section.

Copy link
Copy Markdown
Collaborator

@jmenti jmenti Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshilwant , Bryan's indentation is fine, it is 3 space indentation everywhere. The only place it is 4 space indentation is for Image formats tables and that is because everyone else in that section is also using 4 space indentation. This PR should be merged as is and then someone can go fix the indentation for that section IMO

Copy link
Copy Markdown
Member

@cshilwant cshilwant Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmenti @bryanbrattlof @jeevantelukula

It ended up looking like - https://texasinstruments.github.io/processor-sdk-doc/processor-sdk-linux-AM62LX/esd/docs/11_00_05_02/linux/Foundational_Components/U-Boot/UG-General-Info.html#image-formats

as compared to AM62x where things are fine - https://texasinstruments.github.io/processor-sdk-doc/processor-sdk-linux-AM62X/esd/docs/10_01_10_04/linux/Foundational_Components/U-Boot/UG-General-Info.html#image-formats

StaticRocket
StaticRocket previously requested changes Mar 5, 2025
View reviewed changes
@bryanbrattlof bryanbrattlof force-pushed the am62lx-uboot branch 2 times, most recently from 816dfdd to 5a75128 Compare March 6, 2025 22:16
cshilwant
cshilwant previously requested changes Mar 7, 2025
View reviewed changes
source/linux/Foundational_Components/U-Boot/UG-General-Info.rst
Copy link
Copy Markdown
Member

@cshilwant cshilwant Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/TexasInstruments/processor-sdk-doc/blob/5a75128e8c1127480e13dab183780b39d7af2ee0/source/linux/Foundational_Components/U-Boot/UG-General-Info.rst

@bryanbrattlof The indentation for all your newly added table still seems to be incorrect

@jmenti
Copy link
Copy Markdown
Collaborator

jmenti commented Mar 11, 2025

@bryanbrattlof why are we explaining the bootflow under both "Image Formats" and under "Boot Flow"? Just leave the section under "Image Formats with no description and give a full description of the boorflow under the bootflow section, pretty please (:

@bryanbrattlof
Copy link
Copy Markdown
Collaborator Author

bryanbrattlof commented Mar 11, 2025

no worries. I've removed the paragraphs

@cshilwant cshilwant dismissed their stale review March 13, 2025 06:23

several updates after the last review

@cshilwant cshilwant dismissed StaticRocket’s stale review March 13, 2025 06:23

several updates after the last review

@cshilwant cshilwant requested review from a team, jeevantelukula and sadik-smd March 13, 2025 06:24
StaticRocket
StaticRocket previously approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close enough for now. There's still some indentation issues but I know this file is about to be reworked.

@cshilwant
Copy link
Copy Markdown
Member

cshilwant commented Mar 15, 2025

Looks like 57f78ae was an accidental merge commit?

@StaticRocket
Copy link
Copy Markdown
Member

StaticRocket commented Mar 15, 2025

Well this was correct until @praneethbajjuri modified it. @bryanbrattlof you'll have to rebase and push now.

cshilwant
cshilwant previously requested changes Mar 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix - #204 (comment)

@praneethbajjuri
Copy link
Copy Markdown
Collaborator

praneethbajjuri commented Mar 16, 2025

Well this was correct until @praneethbajjuri modified it. @bryanbrattlof you'll have to rebase and push now.

Yes, my bad .. the rebase messed it up. @bryanbrattlof will send a update in a day removing the merge delta.

@bryanbrattlof bryanbrattlof requested a review from cshilwant March 18, 2025 17:57
@cshilwant cshilwant dismissed their stale review March 18, 2025 19:34

Author has updated the PR

jmenti
jmenti suggested changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jmenti jmenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no major issues but I did nitpick a few details @bryanbrattlof

source/linux/Foundational_Components/U-Boot/UG-General-Info.rst
Copy link
Copy Markdown
Collaborator

@jmenti jmenti Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshilwant , Bryan's indentation is fine, it is 3 space indentation everywhere. The only place it is 4 space indentation is for Image formats tables and that is because everyone else in that section is also using 4 space indentation. This PR should be merged as is and then someone can go fix the indentation for that section IMO

@bryanbrattlof
fix(U-Boot): fix white space issues
b718d99 
There are some weird whitespace inconsistencies. Fix them

Signed-off-by: Bryan Brattlof <bb@ti.com>
@bryanbrattlof
feat(U_boot): add general info for the AM62Lx boot flow
f735be1 
Quite a lot has changed for the AM62Lx boot flow when compared to more
traditional AM62 devices. After hiding un-necessary sections document
via ASCII charts the bootflow between the SMS and A53 cores along with
the memory layout of the 2 SRAM spaces during the boot sequence

Signed-off-by: Bryan Brattlof <bb@ti.com>
@bryanbrattlof
fix(U-Boot): standardize on BL-\d nomenclature
ec6ec8f 
ARM's Trusted firmware Boot Loader (BL) stage 1, 2 and 3 provides a
reference software design for the different phases a CPU can be during
boot. To make things a little more uniform, standardize on using BL-1
for AP Trusted ROM code or BL-31 for EL3 Runtime Firmware

Signed-off-by: Bryan Brattlof <bb@ti.com>
@bryanbrattlof bryanbrattlof requested a review from jmenti March 19, 2025 15:51
@TexasInstruments TexasInstruments deleted a comment from jonaswood01 Mar 19, 2025
@praneethbajjuri praneethbajjuri merged commit 7feedc2 into TexasInstruments:master Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praneethbajjuri praneethbajjuri praneethbajjuri approved these changes

@StaticRocket StaticRocket StaticRocket approved these changes

@uditkumarti uditkumarti Awaiting requested review from uditkumarti uditkumarti is a code owner

@aniket-l aniket-l Awaiting requested review from aniket-l

@VeeruPrudhvi VeeruPrudhvi Awaiting requested review from VeeruPrudhvi VeeruPrudhvi is a code owner

@devarsht devarsht Awaiting requested review from devarsht

@r-vignesh r-vignesh Awaiting requested review from r-vignesh

@jeevantelukula jeevantelukula Awaiting requested review from jeevantelukula jeevantelukula is a code owner

@sadik-smd sadik-smd Awaiting requested review from sadik-smd

@cshilwant cshilwant Awaiting requested review from cshilwant cshilwant is a code owner

+1 more reviewer

@jmenti jmenti jmenti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praneethbajjuri praneethbajjuri

@devarsht devarsht

@r-vignesh r-vignesh

@bryanbrattlof bryanbrattlof

@uditkumarti uditkumarti

@jmenti jmenti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bryanbrattlof @jmenti @cshilwant @StaticRocket @praneethbajjuri @devarsht @r-vignesh @uditkumarti