-
Notifications
You must be signed in to change notification settings - Fork 78
Updated Kernel GPIO driver doc with examples and command-line tools #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New warnings found with rstcheck: |
|
@DhruvaG2000 for review |
|
@jonaswood01 thanks for sending this PR. Review the checker failures. https://github.com/TexasInstruments/processor-sdk-doc/pull/234/checks |
|
New warnings found with rstcheck: |
|
New warnings found with rstcheck: |
madweshanshu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think the man page links should refer to the source rather than the Debian page.
Thank you for linking the GPIO E2E FAQs :)
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
makohoek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jonaswood01,
Thank you for the patch. Looking at the authorship, it seems you are not the author of this patch:
commit 1eb41f7a21f9bb2034c74252f885a71e2ec27cec (jonaswood01/master, jonaswood01/HEAD)
Author: Maxime Fournier <[email protected]>
Date: Tue Apr 1 16:52:17 2025 +0200
docs(GPIO): Updated Kernel driver doc with examples
Replaced Debian links with lgpiod links and cleaned a lengthy URL.
Signed-off-by: Jonas Wood <[email protected]>
Can you please fix this? It seems weird that Maxime is the author here since you are the one submitting the pull request.
This can be fixed with:
$ git commit --amend --reset-author
Also, can you rebase this, please? It seems that this commit modifies some Android files (such as source/android/Foundational_Components_Bootloaders.rst) which seem unrelated to this change.
See: https://docs.github.com/en/get-started/using-git/about-git-rebase for help with git rebase
Not sure what happened exactly, seems that a git pull had included Maxime Fournier's patch in mine unintentionally. But the authorship of this patch (me) should be fixed now, and the Android files (and Maxime's patch) you mentioned are removed from this patch and pull request. |
source/linux/Foundational_Components/Kernel/Kernel_Drivers/GPIO.rst
Outdated
Show resolved
Hide resolved
Updates Linux Kernel GPIO doc with user space examples and resources. Adjusts formatting. Signed-off-by: Jonas Wood <[email protected]>
makohoek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly review Android related things (which are no longer present in this commit).
I confirm that:
- commit authorship looks good
- there are no longer any (unrelated) Android changes in this PR.
I have not thouroughly reviewed anything else, but approving anyways.
In response to the Linux Kernel GPIO in the SDK Docs feeling insufficient. So, this update walks someone through a quick example for using GPIO in user space and provides resources for command-line tools and additional guides.