Skip to content

AM64 U-boot Remote proc support and conditional compile MCUR5 boot variations for J7 devices.#257

Closed
h-nagalla wants to merge 4 commits intoTexasInstruments:masterfrom
h-nagalla:master
Closed

AM64 U-boot Remote proc support and conditional compile MCUR5 boot variations for J7 devices.#257
h-nagalla wants to merge 4 commits intoTexasInstruments:masterfrom
h-nagalla:master

Conversation

@h-nagalla
Copy link
Contributor

a) Add support for AM64 u-boot remote proc boot.
b) Conditional compile of MCU-R5 boot variations for J7 devices.

Copy link
Collaborator

@praneethbajjuri praneethbajjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in commitmsg on "jacinto" name, otherwise lgtm.
@3V3RYONE for review as well.


Cortex-R5F can be used in both lockstep (both cores run same code) and split
mode (each core runs independently).
Cortex-R5F can be used in both lockstep (both cores run same code) and split
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cortex-R5F can be used in both lockstep (both cores run same code) and split
Cortex-R5F can be used in both lockstep (both cores run same code) and split

Do not indent section contents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will fix the indents.

Lockstep and Split mode
^^^^^^^^^^^^^^^^^^^^^^^
.. ifconfig:: CONFIG_part_variant in ('J722S')
.. ifconfig:: (CONFIG_sdk not in ('SITARA')) and (CONFIG_part_variant not in ('J722S'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid use of ifconfig:
https://www.sphinx-doc.org/en/master/usage/extensions/ifconfig.html

Sections count as structural changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm. you mean, we can't use logical boolean expressions to select content? Chrome bowser AI extension suggested this conditional inclusion using python boolean expression.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean the ifconfig directive only masks content. It's not like ifdef. That content is still parsed. The ref engine is a giant state machine that controls all documents references and sections. Because of this the ifconfigs can mask sections that still have a ref, resulting broken links and toctrees. Move the section header outside of the ifconfig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Fixed.

Update documentation to reflect support for both LPDDR4 and DDR4
on AM62L devices.

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
Documentation for u-boot remoteproc loading and starting on AM64x
devices.

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
Sitara devices do not use MCU-R5 for boot purposes. So, keep MCU-R5 specifics
to Jancinto devices.

Signed-off-by: Hari Nagalla <hnagalla@ti.com>
@h-nagalla
Copy link
Contributor Author

Fixed the comments and sending a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants