Skip to content

docs(Debug SPL): Updates U-Boot SPL Debug Guide#272

Merged
praneethbajjuri merged 1 commit intoTexasInstruments:masterfrom
jonaswood01:master
May 13, 2025
Merged

docs(Debug SPL): Updates U-Boot SPL Debug Guide#272
praneethbajjuri merged 1 commit intoTexasInstruments:masterfrom
jonaswood01:master

Conversation

@jonaswood01
Copy link
Contributor

@jonaswood01 jonaswood01 commented Apr 17, 2025

U-Boot SPL Debug SDK docs guide updated for AM62x
using OpenOCD/GDB & CCS examples.

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:187: (ERROR/3) (bash) syntax error near unexpected token `('
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:187: (ERROR/3) (bash) `Open On-Chip Debugger 0.12.0+dev-01925-g169d463a3 (2025-04-04-11:08)'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:233: (ERROR/3) (bash) syntax error near unexpected token `('
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:233: (ERROR/3) (bash) `GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:239: (ERROR/3) (bash) syntax error near unexpected token `tui'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:239: (ERROR/3) (bash) `(gdb) tui enable'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:305: (ERROR/3) (bash) syntax error near unexpected token `('
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:305: (ERROR/3) (bash) `GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:313: (ERROR/3) (bash) syntax error near unexpected token `tui'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:313: (ERROR/3) (bash) `(gdb) tui enable'
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:41: (WARNING/2) Cannot analyze code. No Pygments lexer found for "none".
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:89: (WARNING/2) Cannot analyze code. No Pygments lexer found for "none".
source/linux/Foundational_Components/U-Boot/Apps-SPL-Debug-OpenOCD.rst:95: (WARNING/2) Cannot analyze code. No Pygments lexer found for "none".

cshilwant
cshilwant requested changes Apr 18, 2025
View reviewed changes
@jonaswood01
Copy link
Contributor Author

jonaswood01 commented Apr 21, 2025

@nmenon could you take a look as well?

nmenon
nmenon reviewed Apr 21, 2025
View reviewed changes
Copy link
Contributor

@nmenon nmenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by comments focussing on OpenOCD

@jonaswood01 jonaswood01 requested review from cshilwant and nmenon April 21, 2025 20:20
StaticRocket
StaticRocket reviewed Apr 21, 2025
View reviewed changes
StaticRocket
StaticRocket requested changes Apr 21, 2025
View reviewed changes
bryanbrattlof
bryanbrattlof reviewed Apr 23, 2025
View reviewed changes
@praneethbajjuri
Copy link
Collaborator

praneethbajjuri commented Apr 28, 2025

"Merge branch 'TexasInstruments:master' into master"
Please rebase the patch to master HEAD commit instead. we cannot have merge-commit as part of PR

@jonaswood01
Copy link
Contributor Author

jonaswood01 commented Apr 28, 2025

"Merge branch 'TexasInstruments:master' into master" Please rebase the patch to master HEAD commit instead. we cannot have merge-commit as part of PR

This was an unintentional commit, now removed.

@jonaswood01 jonaswood01 force-pushed the master branch 3 times, most recently from f45fe48 to 6dc42e6 Compare April 28, 2025 21:05
@jonaswood01
Copy link
Contributor Author

jonaswood01 commented Apr 28, 2025

@praneethbajjuri , @r-vignesh , @nmenon , @bryanbrattlof , @jmenti , @StaticRocket, @devarsht , @aniket-l , @cshilwant , @uditkumarti , @VeeruPrudhvi please review as able. All mentioned fixes have been addressed in latest commit --amend push --force. Add'l features should be saved for new PR

@jonaswood01
Copy link
Contributor Author

jonaswood01 commented Apr 28, 2025

@praneethbajjuri , @r-vignesh , @nmenon , @bryanbrattlof , @jmenti , @StaticRocket, @devarsht , @aniket-l , @cshilwant , @uditkumarti , @VeeruPrudhvi please review as able. All mentioned fixes have been addressed in latest commit --amend push --force. Add'l features should be saved for new PR

Unintentional new commit was added to this PR after this comment, which I just removed. No changes made.

StaticRocket
StaticRocket requested changes Apr 28, 2025
View reviewed changes
@jonaswood01 jonaswood01 requested a review from StaticRocket May 12, 2025 20:36
@jonaswood01
docs(Debug_SPL): Updates U-Boot SPL Debug Guide
5dce55b 
U-Boot SPL Debug SDK docs guide updated for AM62x
using OpenOCD/GDB & CCS examples.

Signed-off-by: Jonas Wood <jw@ti.com>
@jonaswood01
Copy link
Contributor Author

jonaswood01 commented May 12, 2025

@praneethbajjuri , @r-vignesh , @nmenon , @bryanbrattlof , @jmenti , @StaticRocket, @devarsht , @aniket-l , @cshilwant , @uditkumarti , @VeeruPrudhvi please review as able. All mentioned fixes have been addressed in latest commit --amend push --force. Add'l features should be saved for new PR

all feedback addressed and fixed. please review when able to close out PR

jmenti
jmenti approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@jmenti jmenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough for initial documentation, thanks for the PR (:

@praneethbajjuri praneethbajjuri merged commit 84487b5 into TexasInstruments:master May 13, 2025
3 checks passed
@StaticRocket StaticRocket mentioned this pull request Jun 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praneethbajjuri praneethbajjuri praneethbajjuri approved these changes

@StaticRocket StaticRocket StaticRocket approved these changes

@cshilwant cshilwant cshilwant approved these changes

@uditkumarti uditkumarti Awaiting requested review from uditkumarti uditkumarti is a code owner

@aniket-l aniket-l Awaiting requested review from aniket-l

@VeeruPrudhvi VeeruPrudhvi Awaiting requested review from VeeruPrudhvi VeeruPrudhvi is a code owner

@devarsht devarsht Awaiting requested review from devarsht

@r-vignesh r-vignesh Awaiting requested review from r-vignesh

@nmenon nmenon Awaiting requested review from nmenon

@bryanbrattlof bryanbrattlof Awaiting requested review from bryanbrattlof

+1 more reviewer

@jmenti jmenti jmenti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praneethbajjuri praneethbajjuri

@devarsht devarsht

@r-vignesh r-vignesh

@bryanbrattlof bryanbrattlof

@uditkumarti uditkumarti

@jmenti jmenti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@jonaswood01 @praneethbajjuri @nmenon @bryanbrattlof @StaticRocket @cshilwant @jmenti @devarsht @r-vignesh @uditkumarti