-
Notifications
You must be signed in to change notification settings - Fork 78
chore: move to exclude only logic #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move to exclude only logic #287
Conversation
|
I've tested this change locally against all DEVFAMILY and OS combinations. It resulted in no difference. |
|
The next logical change will be another PR, where I remove that string concatenation to add the file extension back in and manipulate all the TOC files to include extensions. |
|
+ @jsuhaas22 @jeevantelukula @sadik-smd for reviews |
|
@StaticRocket Getting these warnings when referencing all toc trees. Hope these will be taken care in your follow up PR |
|
That's expected. It's reducing the logic but moving a chunk of the previously suppressed I suppose that does overload the |
8599677
dc01873 to
8599677
Compare
Exclude all documents with an rst suffix not explicitly listed in the toc.txt. This removes a lot of dead logic and unnecessary config values. For a while this project mixed including and excluding document logic, where the include list was provided as an exhaustive description of everything through the toc.txt and a basic exclude list was provided as a sparse array populated manually in the OS tags.py file. This sparse array was supposed to change the way we searched for index files (previously referred to as toctreefiles), but ultimately any index files we needed were already listed in the main toc.txt. Signed-off-by: Randolph Sapp <[email protected]>
8599677 to
82de510
Compare
|
Moved to exclude only logic as this preserves the current warning behavior. Slightly updated to clean up more of the old |
jeevantelukula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chore: move to exclude only logic based on toc.txt
Exclude all documents with an rst suffix not explicitly listed in the toc.txt.
This removes a lot of dead logic and unnecessary config values.
For a while this project mixed including and excluding document logic, where
the include list was provided as an exhaustive description of everything
through the toc.txt and a basic exclude list was provided as a sparse array
populated manually in the OS tags.py file.
This sparse array was supposed to change the way we searched for index files
(previously referred to as toctreefiles), but ultimately any index files we
needed were already listed in the main toc.txt.
Signed-off-by: Randolph Sapp [email protected]
Closes #167