ci(vale): add a pr check workflow for vale#295
Merged
praneethbajjuri merged 3 commits intoTexasInstruments:masterfrom May 23, 2025
Merged
ci(vale): add a pr check workflow for vale#295praneethbajjuri merged 3 commits intoTexasInstruments:masterfrom
praneethbajjuri merged 3 commits intoTexasInstruments:masterfrom
Conversation
Add vale to the main image so we can reuse this container for vale's ci workflow to save some time. Signed-off-by: Randolph Sapp <rs@ti.com>
Use the recommended config directories for the official workflow [1]. Add a vocab accept list for some common terms I see currently being flagged. This will need to be extended. [1] https://github.com/errata-ai/vale-action?tab=readme-ov-file#repository-structure Signed-off-by: Randolph Sapp <rs@ti.com>
Add a pull request driven workflow for vale. This is based on the upstream action documentation [1], but limit it to changed files only to keep feedback snappy. This currently uses a fork I made of the upstream action that's capable of using the locally installed version of vale. This allows us to use our container as is, which is faster than reinstalling tools and makes issues more easily reproducible. This is only required until the upstream PR is accepted [2]. This does not enable this action as a blocking check just yet. There is still an upstream bug that makes all feedback throw a failure, which is a little too aggressive right now. Still need to tune things a bit. [1] https://github.com/errata-ai/vale-action [2] errata-ai/vale-action#149 Signed-off-by: Randolph Sapp <rs@ti.com>
jeevantelukula
approved these changes
May 19, 2025
cshilwant
approved these changes
May 23, 2025
Member
|
@praneethbajjuri / @VeeruPrudhvi / @uditkumarti for final ACK & integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci(vale): add a pr check workflow for vale
Add a pull request driven workflow for vale. This is based on the upstream
action documentation [1], but limit it to changed files only to keep feedback
snappy.
This currently uses a fork I made of the upstream action that's capable of
using the locally installed version of vale. This allows us to use our
container as is, which is faster than reinstalling tools and makes issues more
easily reproducible. This is only required until the upstream PR is accepted
[2].
This does not enable this action as a blocking check just yet. There is still
an upstream bug that makes all feedback throw a failure, which is a little too
aggressive right now. Still need to tune things a bit.
[1] https://github.com/errata-ai/vale-action
[2] feat: allow use of local version of vale errata-ai/vale-action#149
Signed-off-by: Randolph Sapp rs@ti.com
ci(vale): switch style dir, add vocab
Use the recommended config directories for the official workflow [1]. Add a
vocab accept list for some common terms I see currently being flagged. This
will need to be extended.
[1]
https://github.com/errata-ai/vale-action?tab=readme-ov-file#repository-structure
Signed-off-by: Randolph Sapp rs@ti.com
ci(docker): add vale to the main docker image
Add vale to the main image so we can reuse this container for vale's ci
workflow to save some time.
Signed-off-by: Randolph Sapp rs@ti.com