Skip to content

Conversation

@uditkumarti
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@praneethbajjuri praneethbajjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a short commit msg

@StaticRocket
Copy link
Member

Please try addressing the vale comments. You may ignore the ones about abbreviation definitions.

@uditkumarti
Copy link
Collaborator Author

Please try addressing the vale comments. You may ignore the ones about abbreviation definitions.

vale review said tick
vale / vale (pull_request)Successful in 30s

is something else , I am missing

@uditkumarti uditkumarti force-pushed the ufs_support_j784s4 branch from 67a58b8 to bfafd02 Compare July 7, 2025 13:48
praneethbajjuri
praneethbajjuri previously approved these changes Jul 7, 2025
@StaticRocket
Copy link
Member

The vale workflow is non-blocking. It only fails if there are so many warnings that it breaks the Github API comment limits. It will still leave comments over in the review section. Those should still be addressed.

@uditkumarti
Copy link
Collaborator Author

The vale workflow is non-blocking. It only fails if there are so many warnings that it breaks the Github API comment limits. It will still leave comments over in the review section. Those should still be addressed.

I haven't added anything new.. but anyway will fix other warnings

praneethbajjuri
praneethbajjuri previously approved these changes Jul 8, 2025
cshilwant
cshilwant previously approved these changes Jul 10, 2025
@uditkumarti uditkumarti dismissed stale reviews from cshilwant and praneethbajjuri via 863ccdf July 11, 2025 03:57
J784S4 and J742S2 EVM support UFS, so add in doc.

Signed-off-by: Udit Kumar <[email protected]>
@uditkumarti uditkumarti merged commit 649350e into TexasInstruments:master Jul 13, 2025
6 checks passed
@uditkumarti uditkumarti deleted the ufs_support_j784s4 branch August 5, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants