feat(PRU-ICSS): Add firmware name handling #334
Conversation
danish-ti
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
praneethbajjuri
left a comment
praneethbajjuri
left a comment
There was a problem hiding this comment.
Also address vale comments
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet.rst
Outdated
Show resolved
Hide resolved
|
Thanks for the update. Are you sending a followup rev for vale fixes as well ? |
@praneethbajjuri I addressed the vale failures from the first revision. After updating the PR I see that it still has some vale warnings but no vale error. Do we need to address vale warnings as well? |
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
Yes, please review the vale warnings. You can ignore the acronym warnings but please check spelling and passive voice usage.
Also the use of ` is a bit off. One backtick (`) is an inline literal. Two backticks (``) is an inline code section. The parsing is different between the two so please evaluate the usage here. Inline code is normally safer to use if you don't know which to pick.
source/linux/Foundational_Components/PRU-ICSS/Linux_Drivers/PRU_ICSSG_Ethernet.rst
Outdated
Show resolved
Hide resolved
The ICSSG driver reads the firmware names from device tree. Add documentation on how these name are read. Signed-off-by: MD Danish Anwar <[email protected]>
6 participants
The ICSSG driver reads the firmware names from device tree. Add documentation on how these name are read.