docs(linux): AM64x: Update CPSW documentation#337
docs(linux): AM64x: Update CPSW documentation#337chintan013 wants to merge 1 commit intoTexasInstruments:masterfrom
Conversation
chintan013
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
github-actions
bot
assigned
chintan013,
devarsht,
praneethbajjuri,
r-vignesh,
Siddharth-Vadapalli-at-TI and
uditkumarti
|
|
||
| .. note:: | ||
|
|
||
| The DP83869 PHY associated with one of the CPSW interface("eth1" by default) is not included |
There was a problem hiding this comment.
@chintan013, please mention that this requirement is specific to the AM642-EVM or any board in general which uses the DP83968 PHY.
chintan013
force-pushed
the
am64x_cpsw_doc
branch
2 times, most recently
from
0da6523 to
11b6d84
Compare
| The DP83869 PHY associated with one of the CPSW interface("eth1" by default) for AM642-EVM or | ||
| any board in general, does not have it's driver as a built-in module in the kernel, and not | ||
| getting probed during boot up. Therefore, the "eth1" interface must be brought up using the | ||
| commands provided above. |
There was a problem hiding this comment.
This can be shortened as follows:
| The DP83869 PHY associated with one of the CPSW interface("eth1" by default) for AM642-EVM or | |
| any board in general, does not have it's driver as a built-in module in the kernel, and not | |
| getting probed during boot up. Therefore, the "eth1" interface must be brought up using the | |
| commands provided above. | |
| The DP83869 PHY (associated with the eth1 CPSW interface for AM642-EVM) is | |
| not built into the kernel image. It is not available during early boot as | |
| a result, and must be brought up using the commands provided above. |
But I'm more concerned about what you mean here. If it's not built-in it should still be probed once the rootfs is defined and we can perform the usual dt parse and modprobe. This shouldn't change the behavior of the device in a way that requires the manual setup defined above.
There was a problem hiding this comment.
Hello @StaticRocket, During boot time, PHY driver was probed after the script for bringing interface up executed. If we want to bring the interface UP during boot time we need to make changes to the udev script.
Thanks for reviewing the PR, I will apply your suggestions.
There was a problem hiding this comment.
Why are you doing this through udev anyway? We have systemd-networkd present. It should be more than capable of configuring your interfaces as outlined in the scripts shown here...
There was a problem hiding this comment.
Hello @StaticRocket, I have updated the documentation by enabling a systemctl service. For now it is in the documentation, but in the future release we will include it in the filesystem.
There was a problem hiding this comment.
Alright, that's objectively worse. Systemd-networkd should be more than capable of doing this. Why do you want to add more custom scripts and services to work around things already solved by a proper network manager that we already ship?
There was a problem hiding this comment.
My comment still stands...
There was a problem hiding this comment.
@danish-ti , @chintan013 this PR is open since many months . please review and either address with comments to resolve the concerns or move the PR to closed state. TIA
There was a problem hiding this comment.
Hello @praneethbajjuri, The documentation update is already being done with another PR. You can reject this PR.
chintan013
force-pushed
the
am64x_cpsw_doc
branch
from
11b6d84 to
592f397
Compare
CPSW interface associated with DP83869 PHY in AM642-EVM needs to be brought up by adding a systemctl script. Update the documentation to mention the same. Signed-off-by: Chintan Vankar <c-vankar@ti.com>
chintan013
force-pushed
the
am64x_cpsw_doc
branch
from
592f397 to
1c33541
Compare
9 participants
CPSW interface associated with DP83869 PHY in AM64x needs to be brought up by adding a systemctl service. Update the documentation to mention the same.