-
Notifications
You must be signed in to change notification settings - Fork 78
docs(linux): AM64X: Add ICSSG PRP Mode Docs #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Show resolved
Hide resolved
|
New warnings found with rstcheck: |
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Show resolved
Hide resolved
danish-ti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
New warnings found with rstcheck: |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the vale comments and fix the csv table currently generating errors.
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should have been 3 commits with more reasonable information than just docs(linux): AM64X: Update docs, and that's without commenting on https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md#commit-formatting
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Outdated
Show resolved
Hide resolved
|
New issues found with check_toc_txt.py: |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use the feat tag, not the docs tag
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/PRP_Offload.rst
Outdated
Show resolved
Hide resolved
|
New issues found with check_toc_txt.py: |
|
New warnings found with rstcheck: |
|
The commit tags need to be updated. You fixed the first one, but the second one is now wrong. I'd like to suggest: There are also some valid vale warnings (usage of linux instead of Linux, etc.) |
1ae5cec to
681cc02
Compare
- Adds documentation on ICSSG PRP offload mode supported by prueth driver Signed-off-by: Himanshu Mittal <[email protected]>
- Issue Tracker Update containing details of ICSSG firmware
related bugs resolved and bugs open.
- Adds new PRP feature in What's New section
Signed-off-by: Himanshu Mittal <[email protected]>
Adds documentation on PRP offload mode supported by ICSSG