-
Notifications
You must be signed in to change notification settings - Fork 78
AM62D OOB: Audio-DSP-Offload Linux example #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the other feedbacks, comments from vale and commit check workflow needs to be addressed
vale warnings at - https://github.com/TexasInstruments/processor-sdk-doc/pull/355/files#diff-c3ca6facf690bd9373acdba648b491b7255559ecbe93abb8a115e47f861924c8
commit check error at - https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/16195790963/job/45721822147?pr=355
feat(Demo Application): Add Audio-DSP-Offload Linux example as commit message title should be fine. Also, a short commit message can be added
|
New warnings found with rstcheck: |
|
New unreachable files found with check-files.sh: |
|
New warnings found with rstcheck: |
|
@StaticRocket @praneethbajjuri can you please review. |
|
Can you use SVG for graphics where possible? As for images, the "Host GUI Utility" image has multiple of the same step number, but none of this is explained. It also uses the word "Date" instead of "data". |
Addressed review comments. |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As initially requested please address the vale comments on spelling, active voice, etc.
You may ignore the note about common abbreviations.
Also, you'll need to remove the excess : in your commit. Proper formatting would be feat(demos): AM62D Audio-DSP-Offload Linux example
Addressed review comments, acronyms and below 2 warnings are left as they are required. [vale] reported by reviewdog 🐶 [vale] reported by reviewdog 🐶 |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some spelling issues that were truncated due to API rate limits from other warnings
AM62D out-of-box general purpose DSP offload example documentation Signed-off-by: Vishnu Singh <[email protected]>
No description provided.