-
Notifications
You must be signed in to change notification settings - Fork 78
fix(wave5): Update Wave5 Multimedia Documentation #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New warnings found with rstcheck: |
StaticRocket
requested changes
Nov 8, 2024
b4823bd to
597129c
Compare
|
New warnings found with rstcheck: |
|
New warnings found with rstcheck: |
StaticRocket
approved these changes
Nov 26, 2024
Member
|
Ah, you'll need to rebase and squash that last commit but this is fine now. |
Generic edits to the Wave5 multimedia documentation that fixes up some grammar and addresses changes in the new release. Also add in the FFMPEG and MPV information into Wave5 file. These should be subsections under multimedia components rather than separating them into their own page. Signed-off-by: Brandon Brnich <[email protected]>
c3a608d to
8a54777
Compare
Contributor
Author
|
PR has been updated |
|
New warnings found with rstcheck: |
Member
cshilwant
approved these changes
Dec 2, 2024
Member
|
Will wait for +1 from @aniket-l @uditkumarti for J7 specific changes |
Member
@aniket-l Gentle ping on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic edits to the Wave5 multimedia documentation that fixes up some grammar and addresses changes in the new release.
Also add in the FFMPEG and MPV information into Wave5 file. These should be subsections under multimedia components rather than separating them into their own page.