Skip to content

LPM various cleanup and fixes #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
praneethbajjuri merged 7 commits into from
Jul 17, 2025
Merged

LPM various cleanup and fixes #381

praneethbajjuri merged 7 commits into from
Jul 17, 2025

Conversation

@kwillis01
Copy link
Contributor

@kwillis01 kwillis01 commented Jul 15, 2025

  • add schedutil governor to the documentation for CPUFreq governor
  • update references from SDK 11.0 to SDK 11.1
  • remove unimplemented ways to enter MCU Only and Partial I/O
  • remove false assertion that PMIC_LPM_EN signal is 0V when device is in DeepSleep

@github-actions
Copy link

github-actions bot commented Jul 15, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_dfs.rst:55: (ERROR/3) Error in "code-block" directive:
source/linux/Foundational_Components/Power_Management/pm_dfs.rst:65: (ERROR/3) Error in "code-block" directive:
source/linux/Foundational_Components/Power_Management/pm_dfs.rst:71: (ERROR/3) Error in "code-block" directive:

@StaticRocket
Copy link
Member

StaticRocket commented Jul 15, 2025

Please address the vale comments. It did catch at least one valid spelling error.

@StaticRocket
Copy link
Member

StaticRocket commented Jul 15, 2025

There are still pending issues with passive voice

@kwillis01 kwillis01 force-pushed the cleanup branch 2 times, most recently from f2618d5 to 02bc6e2 Compare July 16, 2025 18:24
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_dfs.rst:51: (ERROR/3) Error in "code-block" directive:

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 16, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_dfs.rst:51: (ERROR/3) Error in "code-block" directive:

@kwillis01
fix(pm_low_power_modes): Remove unimplemented features for LPM
dfca306 
Documenting ways to enter low power modes that are not implemented is
unnecessary and can be confusing to users. Remove the unimplemented
features and add them back when they are implemented.

Signed-off-by: Kendall Willis <[email protected]>
kwillis01 added 6 commits July 16, 2025 13:43
@kwillis01
fix(pm_low_power_modes): Move extra LPM confirmation to AM62X only
6ec525d 
The PMIC_LPM_EN signal stays high when the device is in DeepSleep or MCU
Only for AM62P and AM62A. It can only go low in DeepSleep when
programmed on AM62X. Reword and move the extra confirmation to only
appear in AM62X documentation.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
fix(pm_dfs): Add schedutil as a governor
ebd225d 
schedutil is a CPUFreq governor in Linux. schedutil was left out of the
documentation originally.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
chore(Power_Management): Fix references to point to SDK 11.1
d1317c0 
References to the files in the Linux SDK were pointing to SDK 11.0. Fix
them to point to 11.1.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
chore(pm_dfs): Fix whitespaces
d5ee8e1 
This file did not have the three space indentation as specified by the
contributing guide [1]. Fix all cases of this.

[1] https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md#indentation-and-whitespace

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
chore(pm_dfs): Add file styling to referenced files
67203e6 
Referenced files were put into the documentation as normal text. Add the
:file: styling to the referenced files so that it aligns with rest of
documentation.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01
chore(pm_dfs): Fix missing code block
b269d9c 
Add in a code block for a Linux command that is referenced.

Signed-off-by: Kendall Willis <[email protected]>
@kwillis01 kwillis01 requested a review from akashdeep-ti July 17, 2025 14:49
@praneethbajjuri praneethbajjuri merged commit aef493d into TexasInstruments:master Jul 17, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praneethbajjuri praneethbajjuri praneethbajjuri approved these changes

@StaticRocket StaticRocket StaticRocket approved these changes

@cshilwant cshilwant Awaiting requested review from cshilwant cshilwant is a code owner

@uditkumarti uditkumarti Awaiting requested review from uditkumarti uditkumarti is a code owner

@aniket-l aniket-l Awaiting requested review from aniket-l

@VeeruPrudhvi VeeruPrudhvi Awaiting requested review from VeeruPrudhvi VeeruPrudhvi is a code owner

@devarsht devarsht Awaiting requested review from devarsht

@DhruvaG2000 DhruvaG2000 Awaiting requested review from DhruvaG2000

@r-vignesh r-vignesh Awaiting requested review from r-vignesh

@vishalmti vishalmti Awaiting requested review from vishalmti

@akashdeep-ti akashdeep-ti Awaiting requested review from akashdeep-ti

Assignees

@praneethbajjuri praneethbajjuri

@devarsht devarsht

@r-vignesh r-vignesh

@DhruvaG2000 DhruvaG2000

@uditkumarti uditkumarti

@vishalmti vishalmti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kwillis01 @StaticRocket @praneethbajjuri @akashdeep-ti @devarsht @r-vignesh @DhruvaG2000 @uditkumarti @vishalmti