Chore/clean init #458
Merged
Chore/clean init #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get the values we need directly from stat. No need to do goofy string parsing ourselves. Signed-off-by: Randolph Sapp <[email protected]>
Reduce script complexity to that of standard POSIX shells. Adjust shebang accordingly. Signed-off-by: Randolph Sapp <[email protected]>
StaticRocket
requested review from
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
praneethbajjuri
approved these changes
Oct 1, 2025
jeevantelukula
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(init): reduce to posix shell
Reduce script complexity to that of standard POSIX shells. Adjust shebang
accordingly.
Signed-off-by: Randolph Sapp [email protected]
chore(init): remove unnecessary parsing logic
We can get the values we need directly from stat. No need to do goofy string
parsing ourselves.
Signed-off-by: Randolph Sapp [email protected]