Skip to content

Conversation

@jsuhaas22
Copy link
Collaborator

OP-TEE provides secure storage mechanism. Add docs to explain what it is, its uses and how to compile it.

@shiva-ti
Copy link
Collaborator

there's already a section for OPTEE Secure storage in docs - https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/latest/exports/docs/linux/Foundational_Components_OPTEE.html#secure-storage-with-rpmb-for-hs

can we update that itself ? Same can either be linked in the Security overview section, or if you want to add a new security specific rst it can be linked to the existing one, something like - "for more details refer - security specific rst"

@jsuhaas22
Copy link
Collaborator Author

there's already a section for OPTEE Secure storage in docs - https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/latest/exports/docs/linux/Foundational_Components_OPTEE.html#secure-storage-with-rpmb-for-hs

can we update that itself ? Same can either be linked in the Security overview section, or if you want to add a new security specific rst it can be linked to the existing one, something like - "for more details refer - security specific rst"

That section is only for RPMB. I could make it more generic for secure storage and copy this there, though. I wrote a separate page since it was getting long and I didn't want the main page (focused on compilation) to digress. There are links between these two pages in this PR.

@shiva-ti
Copy link
Collaborator

shiva-ti commented Nov 26, 2025

there are some passive voice warnings generated - https://github.com/TexasInstruments/processor-sdk-doc/pull/539/files , please review all those as well

@jsuhaas22
Copy link
Collaborator Author

there are some passive voice warnings generated - https://github.com/TexasInstruments/processor-sdk-doc/pull/539/files , please review all those as well

Done @shiva-ti, the remaining warnings that cause Vale to fail are all "acronym not defined", though I have defined them... or sentence-style capitalization.

@shiva-ti
Copy link
Collaborator

there are some passive voice warnings generated - https://github.com/TexasInstruments/processor-sdk-doc/pull/539/files , please review all those as well

Done @shiva-ti, the remaining warnings that cause Vale to fail are all "acronym not defined", though I have defined them... or sentence-style capitalization.

LGTM, please also mention the platforms in commit message for which you are adding this support

@manorit2001
Copy link
Contributor

manorit2001 commented Nov 27, 2025

Hi @jsuhaas22 , My honest recommendation would be to update https://optee.readthedocs.io/en/latest/architecture/secure_storage.html if something is lacking there in the generic flow for secure storage and have only TI specific overrides ( if we have ) to be documented in TI specific pages. This helps in easier maintenance when upstream migrates and changes and only the TI specific stuff we have to maintain. Also benefits the general community if something is lacking upstream.

@jsuhaas22 jsuhaas22 force-pushed the rpmb-pkcs branch 2 times, most recently from 9ab7ebd to 1fa2613 Compare November 27, 2025 09:32
@jsuhaas22 jsuhaas22 force-pushed the rpmb-pkcs branch 2 times, most recently from 5ced8dd to 85b03cf Compare November 27, 2025 09:56
@jsuhaas22
Copy link
Collaborator Author

Hi @jsuhaas22 , My honest recommendation would be to update https://optee.readthedocs.io/en/latest/architecture/secure_storage.html if something is lacking there in the generic flow for secure storage and have only TI specific overrides ( if we have ) to be documented in TI specific pages. This helps in easier maintenance when upstream migrates and changes and only the TI specific stuff we have to maintain. Also benefits the general community if something is lacking upstream.

Done @manorit2001 . I have trimmed this PR down.

Copy link
Contributor

@manorit2001 manorit2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked

shiva-ti
shiva-ti previously approved these changes Nov 27, 2025
shiva-ti
shiva-ti previously approved these changes Nov 27, 2025
shiva-ti
shiva-ti previously approved these changes Nov 28, 2025
@StaticRocket
Copy link
Member

Alright, this seems fine to me now. Just need to resolve the merge conflict @jsuhaas22

@cshilwant
Copy link
Member

@jsuhaas22 can you resolve the merge conflicts?

@shiva-ti to re-review

Presently, TI's OP-TEE docs speak only of RPMB Secure Storage mechanism,
and not of REE FS. REE FS is supported by-default, so mention it too.

Also add a brief on Secure Storage.

Signed-off-by: Suhaas Joshi <[email protected]>
@jsuhaas22
Copy link
Collaborator Author

I rebased on master. cc: @shiva-ti @cshilwant @StaticRocket

@cshilwant cshilwant merged commit 44ac7ba into TexasInstruments:master Dec 9, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants