-
Notifications
You must be signed in to change notification settings - Fork 78
feat: linux: Add docs on OP-TEE Secure Storage #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
there's already a section for OPTEE Secure storage in docs - https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/latest/exports/docs/linux/Foundational_Components_OPTEE.html#secure-storage-with-rpmb-for-hs can we update that itself ? Same can either be linked in the Security overview section, or if you want to add a new security specific rst it can be linked to the existing one, something like - "for more details refer - security specific rst" |
source/linux/Foundational_Components/System_Security/OPTEE_Secure_Storage.rst
Outdated
Show resolved
Hide resolved
That section is only for RPMB. I could make it more generic for secure storage and copy this there, though. I wrote a separate page since it was getting long and I didn't want the main page (focused on compilation) to digress. There are links between these two pages in this PR. |
source/linux/Foundational_Components/System_Security/OPTEE_Secure_Storage.rst
Outdated
Show resolved
Hide resolved
|
there are some passive voice warnings generated - https://github.com/TexasInstruments/processor-sdk-doc/pull/539/files , please review all those as well |
0708f98 to
3e9afe3
Compare
Done @shiva-ti, the remaining warnings that cause Vale to fail are all "acronym not defined", though I have defined them... or sentence-style capitalization. |
LGTM, please also mention the platforms in commit message for which you are adding this support |
source/linux/Foundational_Components/System_Security/OPTEE_Secure_Storage.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/System_Security/OPTEE_Secure_Storage.rst
Outdated
Show resolved
Hide resolved
|
Hi @jsuhaas22 , My honest recommendation would be to update https://optee.readthedocs.io/en/latest/architecture/secure_storage.html if something is lacking there in the generic flow for secure storage and have only TI specific overrides ( if we have ) to be documented in TI specific pages. This helps in easier maintenance when upstream migrates and changes and only the TI specific stuff we have to maintain. Also benefits the general community if something is lacking upstream. |
9ab7ebd to
1fa2613
Compare
5ced8dd to
85b03cf
Compare
Done @manorit2001 . I have trimmed this PR down. |
manorit2001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acked
a128d2d to
e1e4770
Compare
|
Alright, this seems fine to me now. Just need to resolve the merge conflict @jsuhaas22 |
|
@jsuhaas22 can you resolve the merge conflicts? @shiva-ti to re-review |
Presently, TI's OP-TEE docs speak only of RPMB Secure Storage mechanism, and not of REE FS. REE FS is supported by-default, so mention it too. Also add a brief on Secure Storage. Signed-off-by: Suhaas Joshi <[email protected]>
|
I rebased on master. cc: @shiva-ti @cshilwant @StaticRocket |
OP-TEE provides secure storage mechanism. Add docs to explain what it is, its uses and how to compile it.