-
Notifications
You must be signed in to change notification settings - Fork 78
feat(linux): crypto: Add TRNG and tcrypt documentation for DTHEv2 #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for TRNG (True Random Number Generator) and tcrypt testing capabilities for the DTHEv2 crypto driver on AM62L platforms. The content is adapted from SA2UL_OMAP documentation with platform-specific performance numbers.
Key Changes:
- Added TRNG hardware accelerator usage documentation including driver verification, device access, and testing procedures
- Added tcrypt module performance testing examples with detailed benchmark results for AES encryption/decryption
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/DTHEv2.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/DTHEv2.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/DTHEv2.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/DTHEv2.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/DTHEv2.rst
Outdated
Show resolved
Hide resolved
63f90db to
70443b2
Compare
|
New warnings found with rstcheck: |
TRNG support through OPTEE has been enabled for AM62L. Add TRNG section in DTHEv2. Signed-off-by: T Pratham <[email protected]>
Add Hardware Accelerator Testing section with tcrypt performance test output for DTHEv2. Signed-off-by: T Pratham <[email protected]>
|
Addressed all the review comments. Also, both these sections' contents were directly lifted from SA2UL documentation. Shouldn't all these changes be made there as well? |
|
Good point @Pratham-T , this should probably be moved into a file to be included by both, or a common file to be included by the toc tree of both devices. Either is more useful than direct copy/paste right now considering the tooling didn't change at all between devices. |
Actually, I am thinking to merge both the files by next SDK release. The feature parity is now close to zero, most of the tests made for OMAP/SA2UL devices now also cover DTHEv2. And by next release, this will be all the tests (hopefully). The split was made because in the initial DTHEv2 release, there were a lot of differences, causing a lot of messy |
StaticRocket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, with that in mind I think it's fine to take this as is, considering a larger cleanup is pending.
The support for OPTEE TRNG has been enabled in AM62L. As well as our perf tests are now updated to cover AM62L as well. This PR adds documentation covering the TRNG usage and also adds tcrypt test numbers. The content is same as SA2UL_OMAP documentation with only the performance numbers changed.