Skip to content

Conversation

@Pratham-T
Copy link
Contributor

The support for OPTEE TRNG has been enabled in AM62L. As well as our perf tests are now updated to cover AM62L as well. This PR adds documentation covering the TRNG usage and also adds tcrypt test numbers. The content is same as SA2UL_OMAP documentation with only the performance numbers changed.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for TRNG (True Random Number Generator) and tcrypt testing capabilities for the DTHEv2 crypto driver on AM62L platforms. The content is adapted from SA2UL_OMAP documentation with platform-specific performance numbers.

Key Changes:

  • Added TRNG hardware accelerator usage documentation including driver verification, device access, and testing procedures
  • Added tcrypt module performance testing examples with detailed benchmark results for AES encryption/decryption

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Pratham-T Pratham-T force-pushed the contrib branch 2 times, most recently from 63f90db to 70443b2 Compare December 1, 2025 13:53
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Kernel/Kernel_Drivers/Crypto/DTHEv2.rst:286: (WARNING/2) Title underline too short.

TRNG support through OPTEE has been enabled for AM62L. Add TRNG section
in DTHEv2.

Signed-off-by: T Pratham <[email protected]>
Add Hardware Accelerator Testing section with tcrypt performance test
output for DTHEv2.

Signed-off-by: T Pratham <[email protected]>
@Pratham-T
Copy link
Contributor Author

Addressed all the review comments.
Also reviewed the Vale warnings and corrected most of them. The remaining ones are not very relevant or not possible to correct.

Also, both these sections' contents were directly lifted from SA2UL documentation. Shouldn't all these changes be made there as well?

@StaticRocket
Copy link
Member

Good point @Pratham-T , this should probably be moved into a file to be included by both, or a common file to be included by the toc tree of both devices. Either is more useful than direct copy/paste right now considering the tooling didn't change at all between devices.

@Pratham-T
Copy link
Contributor Author

Good point @Pratham-T , this should probably be moved into a file to be included by both, or a common file to be included by the toc tree of both devices. Either is more useful than direct copy/paste right now considering the tooling didn't change at all between devices.

Actually, I am thinking to merge both the files by next SDK release. The feature parity is now close to zero, most of the tests made for OMAP/SA2UL devices now also cover DTHEv2. And by next release, this will be all the tests (hopefully).

The split was made because in the initial DTHEv2 release, there were a lot of differences, causing a lot of messy ifconfig blocks if kept in the same file. But by next release, I think the only thing different in DTHEv2 will be the performance numbers in the tests (apart from some small configs here and there of course). I think the better course of action seeing the near future here is moving the code-blocks having the test and performance numbers to different files for different crypto engines and include in the main crypto file under respective ifconfig.

Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, with that in mind I think it's fine to take this as is, considering a larger cleanup is pending.

@StaticRocket StaticRocket dismissed cshilwant’s stale review December 3, 2025 22:28

Feedback addressed.

@StaticRocket StaticRocket merged commit eb89942 into TexasInstruments:master Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants