ci(commit-check): ignore the branch check #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The branch check part of the new commit-check action ignores the commit-check conventional_branch configuration option. Using master is sometimes useful for those people who prefer to let the automatic build and deploy workflow run for previews of their changes on their end. If we aren't using merge commits there is no reference to the source branch kept around. I see no reason to bother people with this right now. Fixes: 35d453e ("ci(commit-check): update to version 2") Signed-off-by: Randolph Sapp <[email protected]>
StaticRocket
requested review from
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
The way this is currently done right now is incredibly rudimentary and results in a few false positives. What we've got right now is already a fight as it is. Not sure I can justify this part of the check. Signed-off-by: Randolph Sapp <[email protected]>
Member
|
Lol, imperative check failures on the commit which is gonna disable the same - https://github.com/TexasInstruments/processor-sdk-doc/actions/runs/20090114328/job/57635671662?pr=573 |
cshilwant
approved these changes
Dec 10, 2025
yogeshhegde
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci(commit-check): disable imperative subject check
The way this is currently done right now is incredibly rudimentary and results
in a few false positives. What we've got right now is already a fight as it
is. Not sure I can justify this part of the check.
Signed-off-by: Randolph Sapp [email protected]
ci(commit-check): ignore the branch check
The branch check part of the new commit-check action ignores the commit-check
conventional_branch configuration option.
Using master is sometimes useful for those people who prefer to let the
automatic build and deploy workflow run for previews of their changes on their
end. If we aren't using merge commits there is no reference to the source
branch kept around. I see no reason to bother people with this right now.
Fixes: 35d453e ("ci(commit-check): update to version 2") Signed-off-by:
Randolph Sapp [email protected]