Skip to content

Fixed Text.from_ansi() removing trailing line break. #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed Text.from_ansi() removing trailing line break. #3793

wants to merge 3 commits into from

Conversation

kmvanbrunt
Copy link

@kmvanbrunt kmvanbrunt commented Jul 14, 2025 •
edited
Loading

Type of changes

  • Bug fix
  • Tests

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fixes #3577

Ensures that Text.from_ansi() converts a trailing line break to a newline character instead of removing it.

@kmvanbrunt kmvanbrunt changed the title Fixed issue where Text.from_ansi() was removing trailing line breaks. Fixed issue where Text.from_ansi() was removing ending line break. Jul 14, 2025
@kmvanbrunt kmvanbrunt changed the title Fixed issue where Text.from_ansi() was removing ending line break. Fixed Text.from_ansi() removing a trailing newline. Aug 19, 2025
@kmvanbrunt kmvanbrunt marked this pull request as draft August 20, 2025 00:36
@kmvanbrunt kmvanbrunt changed the title Fixed Text.from_ansi() removing a trailing newline. Fixed Text.from_ansi() removing a trailing line break. Aug 20, 2025
@kmvanbrunt kmvanbrunt changed the title Fixed Text.from_ansi() removing a trailing line break. Fixed Text.from_ansi() removing trailing line break. Aug 20, 2025
@kmvanbrunt kmvanbrunt marked this pull request as ready for review August 20, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Trailing line break removed by Text.from_ansi().

1 participant

@kmvanbrunt