Merge pull request #1168 from Textualize/test-deadlock

fix deadlock on tests

Author: willmcgugan

src/textual/_animator.py

@@ -192,6 +192,8 @@ async def stop(self) -> None:
             await self._timer.stop()
         except asyncio.CancelledError:
             pass
+        finally:
+            self._idle_event.set()
 
     def bind(self, obj: object) -> BoundAnimator:
         """Bind the animator to a given objects."""

src/textual/app.py

@@ -803,9 +803,11 @@ async def run_auto_pilot(
                 terminal_size=size,
             )
         finally:
-            if auto_pilot_task is not None:
-                await auto_pilot_task
-            await app._shutdown()
+            try:
+                if auto_pilot_task is not None:
+                    await auto_pilot_task
+            finally:
+                await app._shutdown()
 
         return app.return_value
 
@@ -1291,6 +1293,10 @@ async def invoke_ready_callback() -> None:
 
                 await self.animator.start()
 
+            except Exception:
+                await self.animator.stop()
+                raise
+
             finally:
                 await self._ready()
                 await invoke_ready_callback()
@@ -1303,10 +1309,11 @@ async def invoke_ready_callback() -> None:
                 pass
             finally:
                 self._running = False
-                for timer in list(self._timers):
-                    await timer.stop()
-
-            await self.animator.stop()
+                try:
+                    await self.animator.stop()
+                finally:
+                    for timer in list(self._timers):
+                        await timer.stop()
 
         self._running = True
         try: