Merge pull request #5650 from Zaloog/lg/fix-select-selection

Bugfix Select.selection with no value selected

Author: willmcgugan

CHANGELOG.md

@@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Static and Label now accept Content objects, satisfying type checkers https://github.com/Textualize/textual/pull/5618
 - Fixed click selection not being disabled when allow_select was set to false https://github.com/Textualize/textual/issues/5627
 - Fixed crash on clicking line API border https://github.com/Textualize/textual/pull/5641
+- Fixed Select.selection now correctly returns None if Select.BLANK is selected instead of an AssertionError
 - Fixed additional spaces after text-wrapping https://github.com/Textualize/textual/pull/5657
 - Added missing `scroll_end` parameter to the `Log.write_line` method https://github.com/Textualize/textual/pull/5672
 - Restored support for blink https://github.com/Textualize/textual/pull/5675

src/textual/widgets/_select.py

@@ -477,7 +477,8 @@ def selection(self) -> SelectType | None:
 
         """
         value = self.value
-        assert not isinstance(value, NoSelection)
+        if isinstance(value, NoSelection):
+            return None
         return value
 
     def _setup_variables_for_options(

tests/select/test_blank_and_clear.py

@@ -63,3 +63,13 @@ def compose(self):
         assert not select.is_blank()
         with pytest.raises(InvalidSelectValueError):
             select.clear()
+
+async def test_selection_is_none_with_blank():
+    class SelectApp(App[None]):
+        def compose(self):
+            yield Select(SELECT_OPTIONS)
+
+    app = SelectApp()
+    async with app.run_test():
+        select = app.query_one(Select)
+        assert select.selection is None