Skip to content

Conversation

@TomJGooding
Copy link
Collaborator

@TomJGooding TomJGooding commented Nov 15, 2024

Fixes #5215.

I've marked this as a draft as I'm not sure if this added _tabs_counter should reflect the Tabs widget?

After looking into this a bit deeper, it seems the Tabs widget already assigns ID's based on a counter. However this counter only increments when the tab ID hasn't been provided.

Should the TabbedContent reflect this setting of ID's? This would make these widgets more consistent, but might be a breaking change.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding
Copy link
Collaborator Author

Closed in favour of #5298.

@TomJGooding TomJGooding deleted the fix-tabbed-content-prevent-duplicate-ids-error branch November 27, 2024 17:51
@darrenburns
Copy link
Member

Sorry Tom - I think Will just missed this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DuplicateIds exception raised when removing a tab and adding a new tab

2 participants