Input selection #5340
Merged
Input selection #5340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Input.cursor_position
willmcgugan
reviewed
Dec 5, 2024
willmcgugan
approved these changes
Dec 5, 2024
Member
willmcgugan
left a comment
willmcgugan
left a comment
There was a problem hiding this comment.
LGTM. Some trivial things.
TomJGooding
added a commit
to TomJGooding/textual
that referenced
this pull request
Dec 15, 2025
When text selection was added to the `Input` widget in Textualize#5340, it was unfortunately overlooked that `MaskedInput` inherits from this widget. Add an override for the `MaskedInput.replace` method to ensure proper functionality when replacing selecting text. Fixes Textualize#5493
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.