fix(text area): fix rendering with a multi-line placeholder #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@TomJGooding Would I be correct in thinking that this won't wrap the placeholder? I.e. if it is wider than the text area, it will crop the lines. The original didn't. But I think if we're going to support multi-line placeholders we may as well go the whole hog and implement wrapping. Hope you don't mind, but I think I might tackle that now. If it isn't too challenging, I should have another PR shortly. |
Merged
Member
|
Closing in favor of #6138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6122
Please review the following checklist.