Improve geometry debug dump to three.js viewer, plus some small checks in geometry processing #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ThatOpen-main
- add number of output curve points in BSpline curves as parameter instead of a fixed number of 20. - add some checks in Nurbs::init() to prevent crashes in case the Nurbs surface is not well defined in the IFC model.
Without ordering, the lines are in a random order, which makes it hard to track issues in exported files
cylinder surface is not reliable enough, use simple triangulation
…() const add IFCCLOTHOID curve type in IfcGeometryLoader::ComputeCurve add function double IfcGeometryLoader::ReadCurveMeasureSelect() const initialize glm::dmat4 transformation = glm::dmat4(1.0); in struct IfcPlacedGeometry to avoid uninitialized variables In IfcGeometry::Normalize() add check if numPoints > 0, otherwise extents will be DBL_MAX/DBL_MIN
…fcLoader to prevent near infinite loop
…value Fix writeline issues
Bumps [koa](https://github.com/koajs/koa) from 2.15.4 to 2.16.0. - [Release notes](https://github.com/koajs/koa/releases) - [Changelog](https://github.com/koajs/koa/blob/master/History.md) - [Commits](koajs/koa@2.15.4...2.16.0) --- updated-dependencies: - dependency-name: koa dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [reusify](https://github.com/mcollina/reusify) from 1.0.4 to 1.1.0. - [Release notes](https://github.com/mcollina/reusify/releases) - [Commits](mcollina/reusify@v1.0.4...v1.1.0) --- updated-dependencies: - dependency-name: reusify dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001700 to 1.0.30001701. - [Commits](browserslist/caniuse-lite@1.0.30001700...1.0.30001701) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [micromark-util-types](https://github.com/micromark/micromark) from 2.0.1 to 2.0.2. - [Release notes](https://github.com/micromark/micromark/releases) - [Commits](https://github.com/micromark/micromark/compare/[email protected]@2.0.2) --- updated-dependencies: - dependency-name: micromark-util-types dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…s with invalid meshes
… with many openings
…ening angle" This reverts commit 4ec0453.
…CurrentArc = _circleSegments;
…TERBOUND, is in fact an outer, not inner bound. Sometimes models have the wrong polygon defined as OUTERBOUND. This patch adds robustness. No noticeable slowdown in test models
…TERBOUND, is in fact an outer, not inner bound. Sometimes models have the wrong polygon defined as OUTERBOUND. This patch adds robustness. No noticeable slowdown in test models fix WASM build
IFCPARAMETERVALUE can be in degrees or radians, depending on the project units #4061= IFCTRIMMEDCURVE(#4060,(IFCPARAMETERVALUE(323.620237484974)),(IFCPARAMETERVALUE(359.30146064255)),.T.,.PARAMETER.); #56380=IFCTRIMMEDCURVE(#56379,(IFCPARAMETERVALUE(0.000000000000000)),(IFCPARAMETERVALUE(5.892128296486300)),.F.,.PARAMETER.);
merge upstream into develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.