-
Notifications
You must be signed in to change notification settings - Fork 0
fix(deps): require datasets from git for Nifti.embed_storage bug fix #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): require datasets from git for Nifti.embed_storage bug fix #4
Conversation
The stable release of HuggingFace datasets (4.4.x) has a critical bug where NIfTI files are uploaded as empty bytes (0 bytes) to Hub because Nifti.embed_storage was broken. The fix is only in the dev branch. Changes: - Add [tool.uv.sources] to override datasets to git version - Bump datasets minimum to >=4.4.0 (Nifti support) - Add huggingface-hub>=0.32.0 (XET storage support) - Add Critical Dependency section to README with verification steps See: huggingface/datasets#7815
|
@coderabbitai review |
WalkthroughThe PR updates dependency versions (datasets 3.4.0→4.4.0, adds huggingface-hub>=0.32.0) and documents a critical dependency requirement via README updates and pyproject.toml configuration changes using git-based source override. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (4)
Comment |
✅ Actions performedReview triggered.
|
Summary
datasets(4.4.x) has a bug whereNifti.embed_storagewas brokenChanges
[tool.uv.sources]to override datasets to install from git>=4.4.0(Nifti feature support)huggingface-hub>=0.32.0dependency (XET storage support)Why This Matters
Without this fix:
push_to_hub(embed_external_files=True)uploads 0-byte filesReferences
Test Plan
ruff checkpassesmypypassesdatasets==4.4.2.dev0is installed from gitNote
This requirement will change once the fix is merged into a stable release. We should monitor HuggingFace datasets releases and update when a stable version includes the fix.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.