Skip to content

Conversation

@luarss
Copy link
Collaborator

@luarss luarss commented Jul 6, 2025

No description provided.

luarss added 2 commits July 6, 2025 12:43
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Copilot AI review requested due to automatic review settings July 6, 2025 12:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the existing Flask mock endpoint with FastAPI and Pydantic models, updates dependencies accordingly, and bumps some front-end packages.

  • Migrate mock_endpoint.py from Flask to FastAPI with typed request/response models
  • Update requirements.txt to remove Flask and add FastAPI
  • Bump Next.js version and introduce new front-end dependencies in package.json

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
frontend/utils/mock_endpoint.py Replaced Flask routes with FastAPI, added Pydantic models, integrated uvicorn.run
frontend/requirements.txt Removed Flask/CORS deps, added fastapi entry
frontend/nextjs-frontend/package.json Updated Next.js version and added @babel/runtime & prismjs
Comments suppressed due to low confidence (3)

frontend/utils/mock_endpoint.py:37

  • [nitpick] The parameter name request conflicts with FastAPI's Request type and may cause confusion; consider renaming it to something like chat_request or payload.
def chat_app(request: ChatRequest) -> ChatResponse:

frontend/utils/mock_endpoint.py:25

  • Consider adding automated tests for the new FastAPI endpoints (/chains/listAll and /graphs/agent-retriever) to validate request parsing and response formatting.
@app.get("/chains/listAll")

frontend/utils/mock_endpoint.py:74

  • The module uses uvicorn.run(...) but uvicorn is not listed in requirements.txt. Please add uvicorn to ensure the server can start without missing dependency errors.
    import uvicorn

Signed-off-by: Jack Luar <[email protected]>
@luarss luarss merged commit e4d2abd into The-OpenROAD-Project:master Jul 6, 2025
2 checks passed
@luarss luarss deleted the topic/fix-dependabot branch July 6, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant