Restore docker-compose healthcheck #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow option to customise healthcheck intervals - update readme Signed-off-by: Jack Luar <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces a configurable Docker healthcheck, exposes its settings through environment variables, updates documentation to guide users in customizing these settings, and cleans up CI workflows by removing fixed sleep timers.
- Enable dynamic healthcheck parameters in
docker-compose.yml - Add corresponding defaults in
backend/.env.example - Revise
README.mdto explain healthcheck customization - Remove hardcoded
sleepfrom CI workflows
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Restore healthcheck block with environment-variable defaults and add frontend dependency on backend health |
| backend/.env.example | Introduce HEALTHCHECK_* variable placeholders |
| README.md | Document how to adjust healthcheck settings |
| .github/workflows/ci.yaml | Remove workaround sleep after Docker startup |
| .github/workflows/ci-secret.yaml | Remove workaround sleep after Docker startup |
Comments suppressed due to low confidence (3)
docker-compose.yml:20
- Using
condition: service_healthyrequires Compose file format version 2.4 or higher. Please ensure the top-levelversionis set accordingly or document the required version in a comment.
depends_on:
README.md:44
- The linked Docker Compose reference appears to be from an older version. Consider updating the URL to the latest Compose file docs (e.g.,
https://docs.docker.com/compose/compose-file/compose-file-v3/#healthcheck) to avoid confusion.
For more information, please refer to this [link](https://docs.docker.com/reference/compose-file/services/#healthcheck)
backend/.env.example:46
- [nitpick] For consistency, quote numeric environment variables (
HEALTHCHECK_RETRIES="5") to match the style of other entries and avoid potential parsing issues.
HEALTHCHECK_RETRIES=5
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
luarss
force-pushed
the
topic/restore-healthcheck
branch
from
94f34bb to
c782508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.