Skip to content

Conversation

@palaniappan-r
Copy link
Collaborator

No description provided.

@palaniappan-r palaniappan-r requested review from Copilot and luarss and removed request for Copilot August 26, 2025 09:33

This comment was marked as outdated.

@palaniappan-r palaniappan-r requested a review from Copilot August 26, 2025 10:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project's dependency management from pip and requirements.txt files to uv, a modern Python package manager. The main goal is to modernize the development workflow and improve dependency management using uv's faster and more reliable package resolution.

Key changes:

  • Replaced requirements.txt files with pyproject.toml using uv's modern dependency specification format
  • Updated all installation and build scripts to use uv commands instead of pip
  • Upgraded Python version requirement from 3.12 to 3.13

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
backend/src/agents/retriever_graph.py Updated import to use newer LangGraph API with CompiledStateGraph
backend/requirements.txt Removed pip-style requirements file
backend/requirements-test.txt Removed separate test requirements file
backend/pyproject.toml Migrated to modern pyproject.toml with uv dependency groups and updated package versions
backend/README.md Updated installation instructions to use uv sync instead of pip
backend/Makefile Replaced pip and virtual environment commands with uv equivalents
backend/Dockerfile_slim Updated Docker build to use uv for dependency management
backend/Dockerfile Updated Docker build to use uv for dependency management
backend/.python-version Set Python version to 3.13
README.md Updated main installation instructions to use uv

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@luarss luarss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just need minor fixes to workflows+Dockerfile. Also please sign off the commits - thanks!

@palaniappan-r palaniappan-r requested a review from luarss August 29, 2025 08:58
luarss
luarss previously approved these changes Sep 4, 2025
Copy link
Collaborator

@luarss luarss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palaniappan-r palaniappan-r requested a review from luarss September 7, 2025 14:12
@luarss luarss merged commit be3b050 into master Sep 10, 2025
2 checks passed
@luarss luarss deleted the uv-deps branch September 10, 2025 18:35
luarss pushed a commit to luarss/ORAssistant that referenced this pull request Oct 18, 2025
…AD-Project#169)

* chore(docs): replace pip install with uv sync instructions

* refactor(Makefile): rewrite setup and checks to use uv

* refactor: use uv in dockerfiles

* chore: update readme

* chore: install uv in Dockerfiles

* refactor(ci): install uv in CI workflow

* fix: update mypy version to >=1.17.1 in pyproject.toml and uv.lock

* chore: update pytest ini_options

* chore: update base image to python:3.13.5-slim in Dockerfiles

* refactor: update Dockerfiles to use pre-built uv images

* refactor(ci): simplify uv installation in CI workflow

* fix: update command to run chatbot script in README

* fix: use uv run in post_install script execution

* chore: update dependencies for mcp functionality

* fix: update type hint for ORFS_DIR environment variable to Optional[str]

* fix: update graph type hint to use Optional

* ruff: fix formatting

* feat: use uv in all make targets

---------

Signed-off-by: Palaniappan R <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants