[Docs] CI for variables.yaml + CI for docs update#2457
[Docs] CI for variables.yaml + CI for docs update#2457vvbandeira merged 10 commits intoThe-OpenROAD-Project:masterfrom
Conversation
oharboe
left a comment
oharboe
left a comment
There was a problem hiding this comment.
Nice! Some nits though.
oharboe
left a comment
oharboe
left a comment
There was a problem hiding this comment.
nits
Also, I think it is worth creating a prior pull request that only updates the formatting of variables.yaml so that this PR does not update the variables.yaml, that way you avoid pull request merge conflicts if this PR needs to be hold off.
luarss
force-pushed
the
topic/yaml-tests
branch
from
b64ab9e to
e26f811
Compare
oharboe
left a comment
oharboe
left a comment
There was a problem hiding this comment.
Suggestion: If FlowVariables.md is modified and it does not match the generatedocs.py result in a PR fail the PR.
|
@oharboe FlowVariables.md changes are detected in the update-pr section. Do you mean to shift it up to the lint section? |
|
I am thinking this is more linting than testing, yes. It is fast enough.... |
yamlfix.toml
Outdated
| @@ -0,0 +1,11 @@ | |||
| explicit_start = true | |||
| line_length = 120 | |||
There was a problem hiding this comment.
It looks like it is being wrapped at 80 characters not 120. 80 is preferable as it match Google style for c++. Does this do anything?
There was a problem hiding this comment.
Yes, it does. The command to run for check is yamlfix -c yamlfix.toml flow/scripts/variables.yaml --check, whereas for format is yamlfix -c yamlfix.toml flow/scripts/variables.yaml. Next PR should reflect line length 80.
luarss
force-pushed
the
topic/yaml-tests
branch
from
50c1d09 to
a50fc37
Compare
luarss
force-pushed
the
topic/yaml-tests
branch
from
4c8cb75 to
3c60cba
Compare
Signed-off-by: Jack Luar <jluar@precisioninno.com>
…ction Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
luarss
force-pushed
the
topic/yaml-tests
branch
from
3c60cba to
8751209
Compare
4 participants
Tracked in #2452
Fixes #2444