scripts: Describe checkpoint in GUI title #2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Screenshots (the ones above don't load for everyone) Before After |
Member
|
Stage is a bit vague as there can be multiple steps within one stage. It might be better to use the odb or def filename (without the path) being loaded as that is more specific. |
Contributor
|
Good point 
|
maliberty
approved these changes
Dec 17, 2024
Contributor
|
@maliberty Sorry Matt I should have placed a more visible notice: This can't go in before we bump OR to get |
Member
|
I usually put "do not merge" in the title. |
Contributor
|
@maliberty can be merged now (OR bump in #2620) |
Member
|
Conflict to resolve |
Signed-off-by: Martin Povišer <[email protected]>
openroad-ci
force-pushed
the
script-gui-title
branch
from
bd51c6d to
4efb98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Waiting on OR update with The-OpenROAD-Project/OpenROAD#6340