[DO NO REVIEW] bazel: local OpenROAD with bazel-orfs#3008
Closed
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Closed
[DO NO REVIEW] bazel: local OpenROAD with bazel-orfs#3008oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Collaborator
Author
|
Once https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/WORKSPACE is fully converted to MODULE.bazel, my expectation is that the below will work. Then bazel-orfs can be updated to have an option to configure |
Collaborator
Author
|
@maliberty @hzeller out of sight and out of mind until OpenROAD is completely converted to MODULE.bazel and WORKSPACE is empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hzeller @maliberty Once OpenROAD uses MODULE.bazel, I'll be able to switch ORFS to use the locally checked out OpenROAD instead of the OpenROAD from the docker image in ORFS bazel-orfs targets:
The workflow locally run build ORFS test designs then becomes:
bazel-orfs needs to grow a capability so that ORFS, a user of bazel-orfs, can set "_openroad" to point to another label:
https://github.com/The-OpenROAD-Project/bazel-orfs/blob/a2e6a3a37693e3ab4c0459d508c08c3c667d2809/openroad.bzl#L384-L390