[AutoTuner] Fix metadata.json regression #3108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending fix: #3025 |
|
The tests should be independent and self-contained. If we need the file, it should be generated by the test. |
luarss
force-pushed
the
topic/avoid-cleanall-at
branch
from
fea45b7 to
a0ead00
Compare
- because clean_all was used, the original metadata.json was nuked. Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
luarss
force-pushed
the
topic/avoid-cleanall-at
branch
from
a0ead00 to
399356c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a metadata.json regression in the AlgoEval tests by ensuring that the correct metadata file is used and the appropriate cleanup is performed.
- Introduces a new class variable "flow_variant" to standardize test naming.
- Updates the reference file name to include the flow variant.
- Modifies make command invocations to pass the FLOW_VARIANT environment variable.
Comments suppressed due to low confidence (1)
tools/AutoTuner/test/smoke_test_algo_eval.py:80
- Consider capturing standard output and error (e.g., using the 'capture_output=True' parameter or redirecting stdout and stderr) to aid in debugging if the subprocess command fails.
out = subprocess.run(command, shell=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
BaseAlgoEvalSmokeTestclass intools/AutoTuner/test/smoke_test_algo_eval.pyto introduce the concept of aflow_variantfor better configurability and reuse. The changes primarily focus on refactoring thesetUpmethod and related commands to use this new variable.Refactoring for
flow_variantintegration:flow_variantwith the default value"smoke-test-algo-eval"to represent the flow variant. ([tools/AutoTuner/test/smoke_test_algo_eval.pyR47-R55](https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/3108/files#diff-63a772b287b174f31b4335be42c7e910f197140112906da7b1bb169517dfacf8R47-R55))setUpmethod to useflow_variantin constructing theexperimentname and thereferencefile path, improving flexibility and consistency. ([tools/AutoTuner/test/smoke_test_algo_eval.pyR47-R55](https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/3108/files#diff-63a772b287b174f31b4335be42c7e910f197140112906da7b1bb169517dfacf8R47-R55))make_basemethod to includeFLOW_VARIANTin allmakecommands, ensuring that the flow variant is explicitly passed to the build system. ([tools/AutoTuner/test/smoke_test_algo_eval.pyL71-R79](https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/3108/files#diff-63a772b287b174f31b4335be42c7e910f197140112906da7b1bb169517dfacf8L71-R79))