Skip to content

Fixed CTS_CLUSTER_SIZE & CTS_CLUSTER_DIAMETER handling#3122

Closed
jeffng-or wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
jeffng-or:cts-fix-cluster-vars
Closed

Fixed CTS_CLUSTER_SIZE & CTS_CLUSTER_DIAMETER handling#3122
jeffng-or wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
jeffng-or:cts-fix-cluster-vars

Conversation

@jeffng-or
Copy link
Contributor

@jeffng-or jeffng-or commented Apr 29, 2025

No description provided.

@jeffng-or jeffng-or force-pushed the cts-fix-cluster-vars branch from 93de955 to b0b0507 Compare April 30, 2025 18:25
@jeffng-or jeffng-or requested review from maliberty and vvbandeira May 1, 2025 18:45
@jeffng-or
Copy link
Contributor Author

The failures are due to metadata changes as a result of fixing the CTS cluster variables. @maliberty , @vvbandeira , Is it OK to set the UpdateRules label and get this change merged?

@maliberty maliberty added the UpdateRules Starts GHA to update rules label May 1, 2025
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 1, 2025
@jeffng-or
Copy link
Contributor Author

Looks like the failures for both pr-head and pr-merge are all rules updates. Setting the UpdateRules label and hoping that it goes through. Looks like it needs a review approval though.

@jeffng-or jeffng-or added the UpdateRules Starts GHA to update rules label May 6, 2025
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 6, 2025
updated sky130hd microwatt CTS cluster variables
updated rules

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@jeffng-or jeffng-or force-pushed the cts-fix-cluster-vars branch from b0b0507 to ab3be9a Compare May 6, 2025 19:56
@jeffng-or
Copy link
Contributor Author

I went ahead and ran the rules files for the failing tests. Here are the updates:

gf180_ibex

Metric Old New Type
finish__timing__setup__ws -1.58 -1.53 Tighten
finish__design__instance__area 899459 1082396 Failing
finish__timing__drv__setup_violation_count 1013 799 Tighten
finish__timing__wns_percent_delay -21.3 -20.21 Tighten

gf180_jpeg

Metric Old New Type
globalroute__antenna_diodes_count 15 10 Tighten
finish__timing__setup__ws -0.08 -0.51 Failing
finish__design__instance__area 2438978 2837982 Failing

gf180_riscv32i

Metric Old New Type
finish__design__instance__area 435127 521614 Failing

nangate45_swerv

Metric Old New Type
finish__timing__setup__ws -0.37 -0.35 Tighten
finish__timing__drv__hold_violation_count 281 584 Failing

sky130hd_microwatt

Metric Old New Type
globalroute__antenna_diodes_count 3810 3594 Tighten
finish__timing__drv__hold_violation_count 106 269 Failing

sky130hd_riscv32i

Metric Old New Type
detailedroute__antenna_diodes_count 21 5 Tighten
finish__design__instance__area 90213 104628 Failing

sky130hs_ibex

Metric Old New Type
globalroute__antenna_diodes_count 30 22 Tighten
detailedroute__route__wirelength 787855 917273 Failing
detailedroute__antenna_diodes_count 38 34 Tighten
finish__timing__setup__ws -0.46 -0.43 Tighten

sky130hs_riscv32i

Metric Old New Type
globalroute__antenna_diodes_count 3 2 Tighten
finish__design__instance__area 124092 143440 Failing

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@jeffng-or
Copy link
Contributor Author

Replaced with #3142

@jeffng-or jeffng-or closed this May 7, 2025
auto-merge was automatically disabled May 7, 2025 17:11

Pull request was closed

@jeffng-or jeffng-or deleted the cts-fix-cluster-vars branch May 9, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants