Skip to content

Comments

flow: update configs and metrics due to update on MPL save and restore#3368

Merged
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:mpl-bug-inconsistent-restore
Aug 11, 2025
Merged

flow: update configs and metrics due to update on MPL save and restore#3368
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:mpl-bug-inconsistent-restore

Conversation

@openroad-ci
Copy link
Collaborator

@openroad-ci openroad-ci commented Jul 31, 2025

Paired with OR PR #7932.

designs/nangate45/tinyRocket/rules-base.json updates:

Metric Old New Type
placeopt__design__instance__area 64635 64542 Tighten
placeopt__design__instance__count__stdcell 32683 32493 Tighten
cts__design__instance__count__setup_buffer 2842 2826 Tighten
cts__design__instance__count__hold_buffer 2842 2826 Tighten
detailedroute__route__wirelength 822134 763092 Tighten
finish__timing__setup__ws -0.13 -0.19 Failing
finish__design__instance__area 67327 66595 Tighten
finish__timing__drv__setup_violation_count 1421 1413 Tighten

designs/gf12/ariane/rules-base.json updates:

Metric Old New Type
detailedroute__route__wirelength 3662425 4407307 Failing
detailedroute__route__drc_errors 1 0 Tighten
finish__timing__setup__ws -212.42 -209.34 Tighten
finish__timing__wns_percent_delay -14.79 -14.56 Tighten

@AcKoucher
Copy link
Contributor

The WL increase in the private design is significant. I think we should go ahead and merge this as it is an important bug fix. However, it would be good to understand the new results.

Perhaps start by comparing post-MPL HPWL.

@maliberty Would you agree?

@maliberty
Copy link
Member

aes-block is still failing

@openroad-ci openroad-ci force-pushed the mpl-bug-inconsistent-restore branch from c8b1aaf to 9f5d29f Compare August 6, 2025 16:45
@joaomai
Copy link
Contributor

joaomai commented Aug 6, 2025

@maliberty
I've updated both OR and ORFS with current masters and ran a secure-CI: aes-block now requires rules update instead of config changes. The secure run railed only on designs that are failing on nightly too. Should I deploy a new run when CI is stable or is this good to go?

@maliberty
Copy link
Member

The public CI is green so go ahead and re-run

joaomai added 4 commits August 7, 2025 13:29
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
@openroad-ci openroad-ci force-pushed the mpl-bug-inconsistent-restore branch from 9f5d29f to e04ad74 Compare August 8, 2025 15:10
@joaomai
Copy link
Contributor

joaomai commented Aug 8, 2025

@maliberty
After updaring ORFS/OR gf12/ariane doesn't require rules update anymore.
All green now.

@maliberty maliberty merged commit 4718111 into The-OpenROAD-Project:master Aug 11, 2025
6 of 8 checks passed
@maliberty maliberty deleted the mpl-bug-inconsistent-restore branch August 11, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants