update OR to rsz-improved-slew-fixing#3725
Merged
maliberty merged 4 commits intoThe-OpenROAD-Project:masterfrom Dec 22, 2025
Merged
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Martin Povišer <povik@cutebit.org>
povik
reviewed
Dec 22, 2025
| set_output_delay $output_delay_value_clock -clock [get_clocks clock] [all_outputs] | ||
|
|
||
| set_load -pin_load 5 [all_inputs] | ||
| set_load -pin_load 5 [all_outputs] |
Contributor
There was a problem hiding this comment.
This is a workaround, see The-OpenROAD-Project/OpenROAD#9099
I'm not sure these set_load commands were intended to be here, i.e. on the inner I2cDeviceCtrl block without pad cells
designs/gf12/gcd/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | globalroute__timing__setup__tns | -481.0 | -1020.0 | Failing | | finish__timing__setup__tns | -161 | -435.0 | Failing | designs/gf12/bp_single/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__hold__ws | -313.0 | -251.0 | Tighten | | cts__timing__hold__tns | -613.0 | -1660.0 | Failing | | globalroute__timing__hold__ws | -327.0 | -253.0 | Tighten | | detailedroute__timing__setup__tns | -1460.0 | -1410.0 | Tighten | | detailedroute__timing__hold__tns | -998.0 | -1550.0 | Failing | | finish__timing__setup__tns | -822.0 | -557.0 | Tighten | designs/gf12/ca53/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__flow__warnings__count:STA-1648 | 276 | 260 | Tighten | | cts__timing__setup__ws | -206.0 | -447.0 | Failing | | cts__timing__setup__tns | -890.0 | -10900.0 | Failing | | globalroute__timing__setup__ws | -100.0 | -377.0 | Failing | | globalroute__timing__setup__tns | -100.0 | -6480.0 | Failing | | globalroute__timing__hold__tns | -935.0 | -1660.0 | Failing | | detailedroute__timing__hold__tns | -60800.0 | -95400.0 | Failing | | finish__timing__setup__ws | -100.0 | -239.0 | Failing | | finish__timing__setup__tns | -100.0 | -1450.0 | Failing | designs/rapidus2hp/ethmac/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -35.9 | -44.1 | Failing | | globalroute__timing__setup__ws | -44.9 | -56.2 | Failing | | globalroute__timing__setup__tns | -1390.0 | -1700.0 | Failing | | finish__timing__setup__ws | -44.9 | -56.2 | Failing | | finish__timing__setup__tns | -1390.0 | -1700.0 | Failing | designs/rapidus2hp/hercules_idecode/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__flow__warnings__count:CTS-0041 | 5 | 6 | Failing | | placeopt__design__instance__area | 12484 | 12438 | Tighten | | cts__timing__setup__ws | -273.0 | -247.0 | Tighten | | cts__timing__setup__tns | -1050000.0 | -959000.0 | Tighten | | globalroute__timing__setup__ws | -150.0 | -164.0 | Failing | | finish__timing__setup__ws | -150.0 | -164.0 | Failing | | finish__design__instance__area | 12763 | 12718 | Tighten | designs/rapidus2hp/hercules_is_int/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -308.0 | -361.0 | Failing | | cts__timing__setup__tns | -3310000.0 | -3190000.0 | Tighten | | globalroute__timing__setup__ws | -166.0 | -164.0 | Tighten | | globalroute__timing__setup__tns | -1420000.0 | -1290000.0 | Tighten | | finish__timing__setup__ws | -166.0 | -164.0 | Tighten | | finish__timing__setup__tns | -1420000.0 | -1290000.0 | Tighten | Signed-off-by: Martin Povišer <povik@cutebit.org>
957feda to
0b0a13b
Compare
maliberty
approved these changes
Dec 22, 2025
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
|
@maliberty missing metrics update restored, CI is green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Could not Update Rules
[ERROR] ihp-sg13g2/i2c-gpio-expander: No metrics found, please check the latest CI build for issues.
Updated Rules
designs/asap7/aes_lvt/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
designs/asap7/ethmac/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
designs/asap7/jpeg_lvt/rules-base.json updates:
designs/asap7/mock-alu/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: clk: 333.0000.
designs/asap7/riscv32i-mock-sram/rules-base.json updates:
designs/asap7/swerv_wrapper/rules-base.json updates:
designs/gf180/aes/rules-base.json updates:
designs/gf180/aes-hybrid/rules-base.json updates:
designs/gf180/ibex/rules-base.json updates:
designs/nangate45/aes/rules-base.json updates:
designs/nangate45/ariane133/rules-base.json updates:
designs/nangate45/black_parrot/rules-base.json updates:
designs/nangate45/bp_multi_top/rules-base.json updates:
designs/nangate45/dynamic_node/rules-base.json updates:
designs/nangate45/gcd/rules-base.json updates:
designs/nangate45/jpeg/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: clk_i: 3.0000.
designs/nangate45/mempool_group/rules-base.json updates:
designs/nangate45/swerv/rules-base.json updates:
designs/nangate45/swerv_wrapper/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: ext_clk: 15.0000.
designs/sky130hd/microwatt/rules-base.json updates:
designs/sky130hs/aes/rules-base.json updates:
designs/sky130hs/gcd/rules-base.json updates:
Messages from CI
[INFO] asap7/minimal not included in CI.
[INFO] gf12 not included in the update.
[INFO] gf55 not included in the update.
[INFO] nangate45/bp_quad not included in CI.
[INFO] rapidus2hp not included in the update.