Fixed coverity issue.

- Using std::move() makes the use of makeUniqueName() API more difficult.
- I think this implementation w/o moving is better.

_____________________________________________________________________________________________
*** CID 1635152:         Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/src/dbSta/src/dbEditHierarchy.cc: 400             in sta::dbEditHierarchy::hierarchicalConnect(odb::dbITerm *, odb::dbITerm *, const char *)()
394             std::string base_name = fmt::format(
395                 "{}", db_network_->name(db_network_->dbToSta(source_pin_flat_net)));
396
397             // Decide a new unique net name to avoid collisions in the lowest common
398             // hierarchy
399             std::string unique_name
>>>     CID 1635152:         Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "base_name" is passed-by-value as parameter to "makeUniqueName", when it could be moved instead.
400                 = makeUniqueName(lowest_common_module, base_name);
401
402             // Create and connect dbModNet
403             source_db_mod_net
404                 = dbModNet::create(lowest_common_module, unique_name.c_str());
405             top_dest_mod_iterm->connect(source_db_mod_net);

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>

Author: jhkim-pii

src/dbSta/src/dbEditHierarchy.cc

@@ -593,24 +593,22 @@ void dbEditHierarchy::cleanUnusedHierPins(
 }
 
 std::string dbEditHierarchy::makeUniqueName(dbModule* module,
-                                            std::string name,
+                                            const std::string& name,
                                             const char* io_type_str) const
 {
-  std::string base_name = name;
+  std::string base_name;
   if (io_type_str) {
     base_name = fmt::format("{}_{}", name, io_type_str);
+  } else {
+    base_name = name;
   }
 
   std::string unique_name = base_name;
   int id = 0;
   while (module->findModBTerm(unique_name.c_str())
          || module->getModNet(unique_name.c_str())) {
     id++;
-    if (io_type_str) {
-      unique_name = fmt::format("{}_{}_{}", name, io_type_str, id);
-    } else {
-      unique_name = fmt::format("{}_{}", base_name, id);
-    }
+    unique_name = fmt::format("{}_{}", base_name, id);
   }
   return unique_name;
 }

src/dbSta/src/dbEditHierarchy.hh

@@ -63,7 +63,7 @@ class dbEditHierarchy
                                dbModITerm*& top_mod_iterm) const;
   void reassociatePinConnection(Pin* pin);
   std::string makeUniqueName(dbModule* module,
-                             std::string name,
+                             const std::string& name,
                              const char* io_type_str = nullptr) const;
 
   // During the addition of new ports and new wiring we may