fix performance-move-const-arg

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/drt/src/io/io.cpp

@@ -1920,8 +1920,7 @@ void io::Parser::setCutLayerProperties(odb::dbTechLayer* layer,
     auto spc = table[0][0];
     con->setDefaultSpacing(spc);
     con->setDefaultCenterToCenter(rule->isCenterToCenter(cutClass1, cutClass2));
-    con->setDefaultCenterAndEdge(
-        rule->isCenterAndEdge(std::move(cutClass1), std::move(cutClass2)));
+    con->setDefaultCenterAndEdge(rule->isCenterAndEdge(cutClass1, cutClass2));
     if (rule->isLayerValid()) {
       if (rule->isSameMetal()) {
         tmpLayer->setLef58SameMetalInterCutSpcTblConstraint(con.get());

src/drt/src/rp/FlexRP_prep.cpp

@@ -360,8 +360,8 @@ void FlexRP::prep_cutSpcTbl()
                    odb::dbTechLayerCutSpacingTableDefRule::SECOND)});
           con->setDefaultCenterToCenter(
               dbRule->isCenterToCenter(cutClass1, cutClass2));
-          con->setDefaultCenterAndEdge(dbRule->isCenterAndEdge(
-              std::move(cutClass1), std::move(cutClass2)));
+          con->setDefaultCenterAndEdge(
+              dbRule->isCenterAndEdge(cutClass1, cutClass2));
         }
       }
     }

src/drt/test/gcTest.cpp

@@ -1276,8 +1276,7 @@ TEST_P(CutSpcTblFixture, cut_spc_tbl)
     table.push_back({{301, 301}, {301, 300}});
   }
 
-  dbRule->setSpacingTable(
-      std::move(table), std::move(row_map), std::move(col_map));
+  dbRule->setSpacingTable(table, row_map, col_map);
   makeLef58CutSpcTbl(3, dbRule);
   frNet* n1 = makeNet("n1");
 

src/grt/src/cugr/src/robin_hood.h

@@ -1774,14 +1774,14 @@ class Table
   {
     ROBIN_HOOD_TRACE(this)
     if (o.mMask) {
-      mHashMultiplier = std::move(o.mHashMultiplier);
+      mHashMultiplier = o.mHashMultiplier;
       mKeyVals = std::move(o.mKeyVals);
-      mInfo = std::move(o.mInfo);
-      mNumElements = std::move(o.mNumElements);
-      mMask = std::move(o.mMask);
-      mMaxNumElementsAllowed = std::move(o.mMaxNumElementsAllowed);
-      mInfoInc = std::move(o.mInfoInc);
-      mInfoHashShift = std::move(o.mInfoHashShift);
+      mInfo = o.mInfo;
+      mNumElements = o.mNumElements;
+      mMask = o.mMask;
+      mMaxNumElementsAllowed = o.mMaxNumElementsAllowed;
+      mInfoInc = o.mInfoInc;
+      mInfoHashShift = o.mInfoHashShift;
       // set other's mask to 0 so its destructor won't do anything
       o.init();
     }
@@ -1794,14 +1794,14 @@ class Table
       if (o.mMask) {
         // only move stuff if the other map actually has some data
         destroy();
-        mHashMultiplier = std::move(o.mHashMultiplier);
+        mHashMultiplier = o.mHashMultiplier;
         mKeyVals = std::move(o.mKeyVals);
-        mInfo = std::move(o.mInfo);
-        mNumElements = std::move(o.mNumElements);
-        mMask = std::move(o.mMask);
-        mMaxNumElementsAllowed = std::move(o.mMaxNumElementsAllowed);
-        mInfoInc = std::move(o.mInfoInc);
-        mInfoHashShift = std::move(o.mInfoHashShift);
+        mInfo = o.mInfo;
+        mNumElements = o.mNumElements;
+        mMask = o.mMask;
+        mMaxNumElementsAllowed = o.mMaxNumElementsAllowed;
+        mInfoInc = o.mInfoInc;
+        mInfoHashShift = o.mInfoHashShift;
         WHash::operator=(std::move(static_cast<WHash&>(o)));
         WKeyEqual::operator=(std::move(static_cast<WKeyEqual&>(o)));
         DataPool::operator=(std::move(static_cast<DataPool&>(o)));

src/odb/src/gdsin/gdsUtil.cpp

@@ -119,7 +119,7 @@ std::map<std::pair<int16_t, int16_t>, std::string> getLayerMap(
       continue;
     }
     const boost::property_tree::ptree& layer = pairs.second;
-    const std::string name = layer.get<std::string>("name", "");
+    std::string name = layer.get<std::string>("name", "");
     const std::string source = layer.get<std::string>("source", "");
     const size_t at_pos = source.find('@');
     const size_t slash_pos = source.find('/');