Merge branch 'The-OpenROAD-Project:master' into gui_fix_through_in_timing_widget

Author: LucasYuki

.github/dependabot.yml

@@ -4,7 +4,3 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
-  - package-ecosystem: "gitsubmodule"
-    directory: "/"
-    schedule:
-      interval: "daily"

.github/workflows/github-actions-clang-tidy.yml

@@ -17,7 +17,7 @@ jobs:
         uses: The-OpenROAD-Project/clang-tidy-review@master
         id: review
         with:
-          clang_tidy_version: 15
+          clang_tidy_version: 19
           build_dir: "./build"
           cmake_command: cmake . -B build
           config_file: ".clang-tidy"

Jenkinsfile

@@ -217,28 +217,33 @@ def bazelTest = {
             checkout scm;
             sh label: 'Setup Docker Image', script: 'docker build -f docker/Dockerfile.bazel -t openroad/bazel-ci .';
         }
-        withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
-            stage('bazelisk test ...') {
-                withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
-                    timeout(time: 120, unit: 'MINUTES') {
-                        def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
-                        try {
-                            try {
-                                sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
-                            } finally {
-                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
-                            }
-                        } catch (e) {
-                            currentBuild.result = 'FAILURE';
+        try {
+            withDockerContainer(args: '-u root -v /var/run/docker.sock:/var/run/docker.sock', image: 'openroad/bazel-ci:latest') {
+                stage('bazelisk test ...') {
+                    withCredentials([string(credentialsId: 'bazel-auth-token-b64', variable: 'BAZEL_AUTH_TOKEN_B64')]) {
+                        timeout(time: 120, unit: 'MINUTES') {
+                            def cmd = 'bazelisk test --config=ci --show_timestamps --test_output=errors --curses=no --force_pic --remote_header="Authorization=Basic $BAZEL_AUTH_TOKEN_B64" --profile=build.profile'
                             try {
-                                sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
-                            } finally {
-                                sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                try {
+                                    sh label: 'Test, using cached results and building a minimum of dependencies', script: cmd + ' ...';
+                                } finally {
+                                    sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                }
+                            } catch (e) {
+                                try {
+                                    sh label: 'Test (keep_going)', script: cmd + ' --keep_going ...';
+                                } catch (e2) {
+                                    currentBuild.result = 'FAILURE';
+                                } finally {
+                                    sh label: 'Analyze build times', script: 'bazelisk analyze-profile build.profile';
+                                }
                             }
                         }
                     }
                 }
             }
+        } catch (IOException e) {
+            echo "Caught: ${e}";
         }
     }
 }

MODULE.bazel

@@ -162,10 +162,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-3911-g99312fa58",
+    image = "docker.io/openroad/orfs:v3.0-3998-gb31abb52d",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "36d3ac23732803c9e47181e167a105c69d4d6927a96782c4a4a27ceca40d8ff8",
+    sha256 = "dc40b4a466dcc394b542f2189422ca1c5480c223926fd7a6844211e23a129117",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -14,6 +14,7 @@
 #include "db_sta/dbNetwork.hh"
 #include "db_sta/dbSta.hh"
 #include "sta/TimingModel.hh"
+#include "utl/Logger.h"
 // Poor include definitions in ABC
 // clang-format off
 #include "misc/st/st.h"

src/cut/src/abc_library_factory.cpp

@@ -20,6 +20,7 @@
 #include "sta/NetworkClass.hh"
 #include "sta/PortDirection.hh"
 #include "sta/SearchPred.hh"
+#include "utl/Logger.h"
 
 namespace cut {
 

src/cut/src/logic_extractor.cpp

@@ -19,6 +19,7 @@
 #include "sta/Liberty.hh"
 #include "sta/NetworkClass.hh"
 #include "sta/Sequential.hh"
+#include "utl/Logger.h"
 
 namespace dft {
 

src/dft/src/cells/ScanCellFactory.cpp

@@ -17,6 +17,7 @@
 #include "sta/Liberty.hh"
 #include "sta/NetworkClass.hh"
 #include "sta/SdcClass.hh"
+#include "utl/Logger.h"
 
 namespace dft::utils {
 

src/dft/src/utils/Utils.cpp

@@ -29,11 +29,6 @@ namespace dpl {
 
 using utl::Logger;
 
-using odb::dbDatabase;
-using odb::dbMaster;
-using odb::dbMasterType;
-using odb::dbTechLayer;
-
 class Node;
 class Group;
 class Master;
@@ -73,7 +68,7 @@ struct GridPt;
 struct DbuPt;
 struct DbuRect;
 
-using dbMasterSeq = std::vector<dbMaster*>;
+using dbMasterSeq = std::vector<odb::dbMaster*>;
 
 using IRDropByPoint = std::map<odb::Point, double>;
 struct GapInfo;
@@ -84,7 +79,7 @@ struct IRDrop;
 class Opendp
 {
  public:
-  Opendp(dbDatabase* db, Logger* logger);
+  Opendp(odb::dbDatabase* db, Logger* logger);
   ~Opendp();
 
   Opendp(const Opendp&) = delete;
@@ -101,7 +96,7 @@ class Opendp
   void reportLegalizationStats() const;
 
   void setPaddingGlobal(int left, int right);
-  void setPadding(dbMaster* master, int left, int right);
+  void setPadding(odb::dbMaster* master, int left, int right);
   void setPadding(odb::dbInst* inst, int left, int right);
   void setDebug(std::unique_ptr<dpl::DplObserver>& observer);
 
@@ -120,7 +115,7 @@ class Opendp
   void optimizeMirroring();
 
   // Place decap cells
-  void addDecapMaster(dbMaster* decap_master, double decap_cap);
+  void addDecapMaster(odb::dbMaster* decap_master, double decap_cap);
   void insertDecapCells(double target, IRDropByPoint& psm_ir_drops);
 
   // Get the instance adjacent to the left or right of a given instance
@@ -150,7 +145,7 @@ class Opendp
   // gap -> sequence of masters to fill the gap
   using GapFillers = std::vector<dbMasterSeq>;
 
-  using MasterByImplant = std::map<dbTechLayer*, dbMasterSeq>;
+  using MasterByImplant = std::map<odb::dbTechLayer*, dbMasterSeq>;
 
   using YCoordToGap = std::map<DbuY, std::vector<GapInfo*>>;
 
@@ -278,7 +273,7 @@ class Opendp
   dbMasterSeq filterFillerMasters(const dbMasterSeq& filler_masters) const;
   MasterByImplant splitByImplant(const dbMasterSeq& filler_masters);
   void setGridCells();
-  dbMasterSeq& gapFillers(dbTechLayer* implant,
+  dbMasterSeq& gapFillers(odb::dbTechLayer* implant,
                           GridX gap,
                           const MasterByImplant& filler_masters_by_implant);
   void placeRowFillers(GridY row,
@@ -292,7 +287,9 @@ class Opendp
   std::vector<int> findDecapCellIndices(const DbuX& gap_width,
                                         const double& current,
                                         const double& target);
-  void insertDecapInPos(dbMaster* master, const DbuX& pos_x, const DbuY& pos_y);
+  void insertDecapInPos(odb::dbMaster* master,
+                        const DbuX& pos_x,
+                        const DbuY& pos_y);
   void insertDecapInRow(const std::vector<GapInfo*>& gaps,
                         DbuY gap_y,
                         DbuX irdrop_x,
@@ -309,7 +306,7 @@ class Opendp
   void setGridLoc(Node* cell, GridX x, GridY y);
 
   Logger* logger_ = nullptr;
-  dbDatabase* db_ = nullptr;
+  odb::dbDatabase* db_ = nullptr;
   odb::dbBlock* block_ = nullptr;
   odb::Rect core_;
 
@@ -331,8 +328,8 @@ class Opendp
 
   // Filler placement.
   // gap (in sites) -> seq of masters by implant
-  std::map<dbTechLayer*, GapFillers> gap_fillers_;
-  std::map<dbMaster*, int> filler_count_;
+  std::map<odb::dbTechLayer*, GapFillers> gap_fillers_;
+  std::map<odb::dbMaster*, int> filler_count_;
   bool have_fillers_ = false;
 
   // Decap placement.