Merge pull request #277 from The-OpenROAD-Project/dbsta_cleanup

Dbsta cleanup

Author: jjcherry56

src/dbSta/src/dbNetwork.cc

@@ -194,11 +194,11 @@ class DbInstancePinIterator : public InstancePinIterator
   dbSet<dbITerm>::iterator iitr_end_;
   dbSet<dbBTerm>::iterator bitr_;
   dbSet<dbBTerm>::iterator bitr_end_;
-  Pin *pin_;
+  Pin *next_;
 };
 
 DbInstancePinIterator::DbInstancePinIterator(const Instance *inst,
-						     const dbNetwork *network) :
+					     const dbNetwork *network) :
   network_(network)
 {
   top_ = (inst == network->topInstance());
@@ -222,36 +222,30 @@ DbInstancePinIterator::hasNext()
       return false;
     else {
       dbBTerm *bterm = *bitr_;
+      next_ = network_->dbToSta(bterm);
       bitr_++;
-      pin_ = network_->dbToSta(bterm);
       return true;
     }
   }
-  if (iitr_ == iitr_end_)
-    return false;
   else {
-    dbITerm *iterm = *iitr_;
-    while (iterm->getSigType() == dbSigType::POWER
-	   || iterm->getSigType() == dbSigType::GROUND) {
-      iitr_++;
-      if (iitr_ == iitr_end_)
-	return false;
-      iterm = *iitr_;
-    }
-    if (iitr_ == iitr_end_)
-      return false;
-    else {
-      pin_ = network_->dbToSta(iterm);
+    while (iitr_ != iitr_end_) {
+      dbITerm *iterm = *iitr_;
+      if (!(iterm->getSigType() == dbSigType::POWER
+	    || iterm->getSigType() == dbSigType::GROUND)) {
+	next_ = network_->dbToSta(*iitr_);
+	++iitr_;
+	return true;
+      }
       iitr_++;
-      return true;
     }
+    return false;
   }
 }
 
 Pin *
 DbInstancePinIterator::next()
 {
-  return pin_;
+  return next_;
 }
 
 ////////////////////////////////////////////////////////////////
@@ -266,46 +260,41 @@ class DbNetPinIterator : public NetPinIterator
 
 private:
   const dbNetwork *network_;
-  dbSet<dbITerm>::iterator _iitr;
-  dbSet<dbITerm>::iterator _iitr_end;
-  void *_term;
+  dbSet<dbITerm>::iterator iitr_;
+  dbSet<dbITerm>::iterator iitr_end_;
+  Pin *next_;
 };
 
 DbNetPinIterator::DbNetPinIterator(const Net *net,
 				   const dbNetwork *network) :
   network_(network)
 {
   dbNet *dnet = reinterpret_cast<dbNet*>(const_cast<Net*>(net));
-  _iitr = dnet->getITerms().begin();
-  _iitr_end = dnet->getITerms().end();
-  _term = NULL;
+  iitr_ = dnet->getITerms().begin();
+  iitr_end_ = dnet->getITerms().end();
+  next_ = nullptr;
 }
 
 bool 
 DbNetPinIterator::hasNext()
 {
-  if (_iitr != _iitr_end) {
-    dbITerm *iterm = *_iitr;
-    while (iterm->getSigType() == dbSigType::POWER
-          || iterm->getSigType() == dbSigType::GROUND) {
-      ++_iitr;
-      if (_iitr == _iitr_end) break;
-      iterm = *_iitr;
+  while (iitr_ != iitr_end_) {
+    dbITerm *iterm = *iitr_;
+    if (!(iterm->getSigType() == dbSigType::POWER
+	  || iterm->getSigType() == dbSigType::GROUND)) {
+      next_ = reinterpret_cast<Pin*>(*iitr_);
+      ++iitr_;
+      return true;
     }
+    iitr_++;
   }
-  if (_iitr != _iitr_end) {
-    _term = (void*)(*_iitr);
-    ++_iitr;
-    return true;
-  }
-  else
-    return false;
+  return false;
 }
 
 Pin *
 DbNetPinIterator::next()
 {
-  return (Pin*)_term;
+  return next_;
 }
 
 ////////////////////////////////////////////////////////////////
@@ -314,7 +303,7 @@ class DbNetTermIterator : public NetTermIterator
 {
 public:
   DbNetTermIterator(const Net *net,
-			const dbNetwork *network);
+		    const dbNetwork *network);
   bool hasNext();
   Term *next();
 
@@ -325,7 +314,7 @@ class DbNetTermIterator : public NetTermIterator
 };
 
 DbNetTermIterator::DbNetTermIterator(const Net *net,
-					     const dbNetwork *network) :
+				     const dbNetwork *network) :
   network_(network)
 {
   dbNet *dnet = network_->staToDb(net);
@@ -467,7 +456,7 @@ dbNetwork::findPin(const Instance *instance,
   else {
     dbInst *dinst = staToDb(instance);
     dbITerm *iterm = dinst->findITerm(port_name);
-    return reinterpret_cast<Pin*>(iterm);
+    return dbToSta(iterm);
   }
 }
 
@@ -481,7 +470,7 @@ dbNetwork::findPin(const Instance *instance,
 
 Net *
 dbNetwork::findNet(const Instance *instance, 
-		       const char *net_name) const
+		   const char *net_name) const
 {
   if (instance == top_instance_) {
     dbNet *dnet = block_->findNet(net_name);
@@ -684,8 +673,8 @@ dbNetwork::termIterator(const Net *net) const
 // override ConcreteNetwork::visitConnectedPins
 void
 dbNetwork::visitConnectedPins(const Net *net,
-				    PinVisitor &visitor,
-				    ConstNetSet &visited_nets) const
+			      PinVisitor &visitor,
+			      ConstNetSet &visited_nets) const
 {
   Network::visitConnectedPins(net, visitor, visited_nets);
 }
@@ -737,7 +726,8 @@ DbConstantPinIterator::hasNext()
 }
 
 void
-DbConstantPinIterator::next(Pin *&pin, LogicValue &value)
+DbConstantPinIterator::next(Pin *&pin,
+			    LogicValue &value)
 {
   value = LogicValue::zero;
   pin = nullptr;
@@ -759,8 +749,8 @@ dbNetwork::isLinked() const
 
 bool
 dbNetwork::linkNetwork(const char *,
-			   bool ,
-			   Report *)
+		       bool ,
+		       Report *)
 {
   // Not called.
   return true;
@@ -1088,18 +1078,24 @@ dbNetwork::staToDb(const Pin *pin,
 		   dbITerm *&iterm,
 		   dbBTerm *&bterm) const
 {
-  dbObject *obj = reinterpret_cast<dbObject*>(const_cast<Pin*>(pin));
-  dbObjectType type = obj->getObjectType();
-  if (type == dbITermObj) {
-    iterm = static_cast<dbITerm*>(obj);
-    bterm = nullptr;
+  if (pin) {
+    dbObject *obj = reinterpret_cast<dbObject*>(const_cast<Pin*>(pin));
+    dbObjectType type = obj->getObjectType();
+    if (type == dbITermObj) {
+      iterm = static_cast<dbITerm*>(obj);
+      bterm = nullptr;
+    }
+    else if (type == dbBTermObj) {
+      iterm = nullptr;
+      bterm = static_cast<dbBTerm*>(obj);
+    }
+    else
+      internalError("pin is not ITerm or BTerm");
   }
-  else if (type == dbBTermObj) {
+  else {
     iterm = nullptr;
-    bterm = static_cast<dbBTerm*>(obj);
+    bterm = nullptr;
   }
-  else
-    internalError("pin is not ITerm or BTerm");
 }
 
 dbBTerm *