pdn: add checks for layers existing for connections

Signed-off-by: Peter Gadfort <[email protected]>

Author: gadfort

src/pdn/src/grid.cpp

@@ -702,8 +702,16 @@ void Grid::checkSetup() const
     }
   }
 
-  // add bterms
+  // add bterms and exisiting routing
   for (auto* net : nets) {
+    for (auto* swire : net->getSWires()) {
+      for (auto* box : swire->getWires()) {
+        auto* layer = box->getTechLayer();
+        if (layer) {
+          check_layers.insert(layer);
+        }
+      }
+    }
     for (auto* bterm : net->getBTerms()) {
       for (auto* bpin : bterm->getBPins()) {
         if (!bpin->getPlacementStatus().isFixed()) {
@@ -731,7 +739,7 @@ void Grid::checkSetup() const
       getLogger()->error(utl::PDN,
                          113,
                          "Cannot find shapes to connect to on {}",
-                         connect->getLowerLayer()->getName());
+                         connect->getUpperLayer()->getName());
     }
   }
 }

src/pdn/test/BUILD

@@ -25,6 +25,7 @@ COMPULSORY_TESTS = [
     "core_grid_auto_domain_multiple_nets",
     "core_grid_bad_metal_specs",
     "core_grid_check_connect_layers",
+    "core_grid_check_connect_layers_at_setup",
     "core_grid_cut_pitch",
     "core_grid_dual_followpins",
     "core_grid_dual_followpins_error",

src/pdn/test/CMakeLists.txt

@@ -24,6 +24,7 @@ or_integration_tests(
     core_grid_auto_domain_multiple_nets
     core_grid_bad_metal_specs
     core_grid_check_connect_layers
+    core_grid_check_connect_layers_at_setup
     core_grid_cut_pitch
     core_grid_dual_followpins
     core_grid_dual_followpins_error

src/pdn/test/core_grid_check_connect_layers_at_setup.ok

@@ -0,0 +1,9 @@
+[INFO ODB-0227] LEF file: Nangate45/Nangate45.lef, created 22 layers, 27 vias, 135 library cells
+[INFO ODB-0128] Design: gcd
+[INFO ODB-0130]     Created 54 pins.
+[INFO ODB-0131]     Created 482 components and 2074 component-terminals.
+[INFO ODB-0133]     Created 385 nets and 1110 connections.
+[ERROR PDN-0111] Pin layer metal6 is not a valid shape in Core
+PDN-0111
+[ERROR PDN-0113] Cannot find shapes to connect to on metal5
+PDN-0113

src/pdn/test/core_grid_check_connect_layers_at_setup.tcl

@@ -0,0 +1,44 @@
+# test for rejesting incorrect layers at runtime
+source "helpers.tcl"
+
+read_lef Nangate45/Nangate45.lef
+read_def nangate_gcd/floorplan.def
+
+add_global_connection -net VDD -pin_pattern VDD -power
+add_global_connection -net VSS -pin_pattern VSS -ground
+
+set_voltage_domain -power VDD -ground VSS
+
+define_pdn_grid -name "Core" -pins metal6
+add_pdn_stripe -followpins -layer metal1
+add_pdn_stripe -followpins -layer metal2
+
+add_pdn_stripe -layer metal4 -width 0.48 -pitch 15.0 -offset 2.0
+add_pdn_stripe -layer metal7 -width 1.40 -pitch 20.0 -offset 2.0
+
+add_pdn_connect -layers {metal1 metal2}
+add_pdn_connect -layers {metal2 metal4}
+add_pdn_connect -layers {metal4 metal7}
+
+# Check pin layer
+catch {pdngen} err
+puts $err
+
+pdngen -reset
+
+set_voltage_domain -power VDD -ground VSS
+
+define_pdn_grid -name "Core" -pins metal7
+add_pdn_stripe -followpins -layer metal1
+add_pdn_stripe -followpins -layer metal2
+
+add_pdn_stripe -layer metal4 -width 0.48 -pitch 15.0 -offset 2.0
+add_pdn_stripe -layer metal7 -width 1.40 -pitch 20.0 -offset 2.0
+
+add_pdn_connect -layers {metal1 metal2}
+add_pdn_connect -layers {metal2 metal5}
+add_pdn_connect -layers {metal4 metal7}
+
+# Check connect layer metal5 invalid
+catch {pdngen} err
+puts $err

src/pdn/test/power_switch.py

@@ -44,7 +44,6 @@
 pdn_aux.add_pdn_stripe(design, layer="met5", width=1.600, pitch=27.200, offset=13.600)
 
 pdn_aux.add_pdn_connect(design, layers=["met1", "met4"])
-pdn_aux.add_pdn_connect(design, layers=["met2", "met4"])
 pdn_aux.add_pdn_connect(design, layers=["met4", "met5"])
 
 design.getPdnGen().report()