Merge pull request #8519 from Pinata-Consulting/mock-array-whittling-away

maliberty · web-flow · commit c2ab7c1abbe4 · 2025-10-02T20:16:36.000Z
Mock array whittling away
diff --git a/test/orfs/mock-array/BUILD b/test/orfs/mock-array/BUILD
@@ -49,13 +49,14 @@ placement_grid_y = 0.048 * MOCK_ARRAY_SCALE
 #
 #  pitch_x, pitch_y - placement pitch for each Element, in x and y direction
 # specification are in unit of placement grid
-rows = 8
+rows = 4
 
-cols = 8
+cols = 4
 
-ce_x = 20
+# Use smallest working value for minimum area of test-case
+ce_x = 8
 
-ce_y = 20
+ce_y = 8
 
 # Element size is set to multiple of placement grid above
 ce_width = ce_x * placement_grid_x
@@ -69,19 +70,19 @@ pitch_x = ce_width
 pitch_y = ce_height + (placement_grid_y * 2)
 
 # top level core offset
-margin_x = placement_grid_x
+margin_x = placement_grid_x * 2
 
-margin_y = placement_grid_y
+margin_y = placement_grid_y * 2
 
 # Element core margin
 ce_margin_x = placement_grid_x * 0.5
 
 ce_margin_y = placement_grid_y * 0.5
 
 # PDN problems if it is smaller. Not investigated.
-array_spacing_x = margin_x * 2
+array_spacing_x = placement_grid_x * 4
 
-array_spacing_y = margin_y * 2
+array_spacing_y = placement_grid_y * 4
 
 # top level core and die size, we need some space around the
 # array to put some flip flops and buffers for top level io pins
@@ -90,7 +91,7 @@ core_width = (
 )
 
 core_height = (
-    pitch_y * (rows - 1) + ce_height + margin_x * 2
+    pitch_y * (rows - 1) + ce_height + margin_y * 2
 )
 
 die_width = core_width + (array_spacing_x * 2)
@@ -371,6 +372,21 @@ MACROS = [
     srcs = [
         "simulate.cpp",
     ],
+    # Best way to refer to static names in Verilator generated code?
+    copts = [
+        "-DARRAY_COLS=\"{}\"".format(
+            ",".join([
+                "&top->io_ins_down_{col}, &top->io_ins_up_{col}".format(col = col)
+                for col in range(cols)
+            ]),
+        ),
+        "-DARRAY_ROWS=\"{}\"".format(
+            ",".join([
+                "&top->io_ins_left_{row}, &top->io_ins_right_{row}".format(row = row)
+                for row in range(rows)
+            ]),
+        ),
+    ],
     cxxopts = [
         "-std=c++23",
     ],
@@ -429,6 +445,8 @@ POWER_TESTS = [
             ),
         ],
         arguments = {
+            "ARRAY_COLS": str(cols),
+            "ARRAY_ROWS": str(rows),
             "LOAD_POWER_TCL": "$(location :load_power.tcl)",
             "OPENROAD_EXE": "$(location //src/sta:opensta)",
             "OUTPUT": "$(location :{name}_{stage}.txt)".format(
diff --git a/test/orfs/mock-array/constraints.sdc b/test/orfs/mock-array/constraints.sdc
@@ -2,4 +2,6 @@ set clk_name clock
 set clk_port_name clock
 set clk_period 250
 
+set reg2out_max 160
+
 source $env(PLATFORM_DIR)/constraints.sdc
diff --git a/test/orfs/mock-array/load_power.tcl b/test/orfs/mock-array/load_power.tcl
@@ -14,8 +14,8 @@ log_cmd link_design MockArray
 log_cmd read_sdc $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).sdc
 log_cmd read_spef $::env(RESULTS_DIR)/$::env(POWER_STAGE_STEM).spef
 puts "read_spef for ces_*_* macros"
-for { set x 0 } { $x < 8 } { incr x } {
-  for { set y 0 } { $y < 8 } { incr y } {
+for { set x 0 } { $x < $::env(ARRAY_COLS) } { incr x } {
+  for { set y 0 } { $y < $::env(ARRAY_ROWS) } { incr y } {
     log_cmd read_spef -path ces_${x}_${y} \
       $::env(RESULTS_DIR)/../../Element/base/$::env(POWER_STAGE_STEM).spef
   }
diff --git a/test/orfs/mock-array/power_instances.tcl b/test/orfs/mock-array/power_instances.tcl
@@ -1,8 +1,11 @@
 source $::env(LOAD_POWER_TCL)
 
 set instances [get_cells ces*/io_outs_*_mult]
-if { [llength $instances] != (64 * 4) } {
-  puts "Error: Expected to find 64 Elements * 4 Multiplier instances, found [llength $instances]"
+
+set num [expr $::env(ARRAY_COLS) * $::env(ARRAY_ROWS) * 4]
+
+if { [llength $instances] != $num } {
+  puts "Error: Expected to find $num instances, found [llength $instances]"
   exit 1
 }
 
diff --git a/test/orfs/mock-array/rules-base.json b/test/orfs/mock-array/rules-base.json
@@ -1,42 +1,42 @@
 {
     "synth__design__instance__area__stdcell": {
-        "value": 14315.22,
+        "value": 3556.84,
         "compare": "<="
     },
     "constraints__clocks__count": {
         "value": 1,
         "compare": "=="
     },
     "placeopt__design__instance__area": {
-        "value": 137855,
+        "value": 5719,
         "compare": "<="
     },
     "placeopt__design__instance__count__stdcell": {
-        "value": 9152,
+        "value": 3950,
         "compare": "<="
     },
     "detailedplace__design__violations": {
         "value": 0,
         "compare": "=="
     },
     "cts__design__instance__count__setup_buffer": {
-        "value": 796,
+        "value": 344,
         "compare": "<="
     },
     "cts__design__instance__count__hold_buffer": {
-        "value": 1614,
+        "value": 344,
         "compare": "<="
     },
     "globalroute__antenna_diodes_count": {
         "value": 0,
         "compare": "<="
     },
     "detailedroute__route__wirelength": {
-        "value": 127790,
+        "value": 39799,
         "compare": "<="
     },
     "detailedroute__route__drc_errors": {
-        "value": 1,
+        "value": 0,
         "compare": "<="
     },
     "detailedroute__antenna__violating__nets": {
@@ -48,23 +48,23 @@
         "compare": "<="
     },
     "finish__timing__setup__ws": {
-        "value": -115.35,
+        "value": -0.89,
         "compare": ">="
     },
     "finish__design__instance__area": {
-        "value": 138047,
+        "value": 5728,
         "compare": "<="
     },
     "finish__timing__drv__setup_violation_count": {
-        "value": 1040,
+        "value": 172,
         "compare": "<="
     },
     "finish__timing__drv__hold_violation_count": {
-        "value": 152,
+        "value": 100,
         "compare": "<="
     },
     "finish__timing__wns_percent_delay": {
-        "value": -40.47,
+        "value": -10.0,
         "compare": ">="
     }
 }
diff --git a/test/orfs/mock-array/rules-flat.json b/test/orfs/mock-array/rules-flat.json
@@ -1,42 +1,42 @@
 {
     "synth__design__instance__area__stdcell": {
-        "value": 14315.22,
+        "value": 3556.84,
         "compare": "<="
     },
     "constraints__clocks__count": {
         "value": 1,
         "compare": "=="
     },
     "placeopt__design__instance__area": {
-        "value": 137855,
+        "value": 5719,
         "compare": "<="
     },
     "placeopt__design__instance__count__stdcell": {
-        "value": 9152,
+        "value": 3950,
         "compare": "<="
     },
     "detailedplace__design__violations": {
         "value": 0,
         "compare": "=="
     },
     "cts__design__instance__count__setup_buffer": {
-        "value": 796,
+        "value": 344,
         "compare": "<="
     },
     "cts__design__instance__count__hold_buffer": {
-        "value": 1614,
+        "value": 344,
         "compare": "<="
     },
     "globalroute__antenna_diodes_count": {
         "value": 0,
         "compare": "<="
     },
     "detailedroute__route__wirelength": {
-        "value": 127790,
+        "value": 39799,
         "compare": "<="
     },
     "detailedroute__route__drc_errors": {
-        "value": 1,
+        "value": 0,
         "compare": "<="
     },
     "detailedroute__antenna__violating__nets": {
@@ -48,23 +48,23 @@
         "compare": "<="
     },
     "finish__timing__setup__ws": {
-        "value": -115.35,
+        "value": -0.89,
         "compare": ">="
     },
     "finish__design__instance__area": {
-        "value": 138047,
+        "value": 5728,
         "compare": "<="
     },
     "finish__timing__drv__setup_violation_count": {
-        "value": 1040,
+        "value": 172,
         "compare": "<="
     },
     "finish__timing__drv__hold_violation_count": {
-        "value": 152,
+        "value": 100,
         "compare": "<="
     },
     "finish__timing__wns_percent_delay": {
-        "value": -40.47,
+        "value": -10.0,
         "compare": ">="
     }
 }
diff --git a/test/orfs/mock-array/simulate.cpp b/test/orfs/mock-array/simulate.cpp
@@ -37,18 +37,10 @@ int main(int argc, char** argv)
   top->reset = 1;
   top->clock = 0;
 
-  QData* inputs[]
-      = {&top->io_ins_down_0,  &top->io_ins_down_1,  &top->io_ins_down_2,
-         &top->io_ins_down_3,  &top->io_ins_down_4,  &top->io_ins_down_5,
-         &top->io_ins_down_6,  &top->io_ins_down_7,  &top->io_ins_left_0,
-         &top->io_ins_left_1,  &top->io_ins_left_2,  &top->io_ins_left_3,
-         &top->io_ins_left_4,  &top->io_ins_left_5,  &top->io_ins_left_6,
-         &top->io_ins_left_7,  &top->io_ins_right_0, &top->io_ins_right_1,
-         &top->io_ins_right_2, &top->io_ins_right_3, &top->io_ins_right_4,
-         &top->io_ins_right_5, &top->io_ins_right_6, &top->io_ins_right_7,
-         &top->io_ins_up_0,    &top->io_ins_up_1,    &top->io_ins_up_2,
-         &top->io_ins_up_3,    &top->io_ins_up_4,    &top->io_ins_up_5,
-         &top->io_ins_up_6,    &top->io_ins_up_7};
+  // There's no great way to do this, we need to
+  // refer to static names from Verilator generated code,
+  // inject them on the command line.
+  QData* inputs[] = {ARRAY_COLS, ARRAY_ROWS};
 
   top->trace(vcd, 99);  // Trace all levels of hierarchy
   vcd->open(args.front().data());
