Cleanup: Fix missing header in parsers.h and some clang-tidy issues. #6418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The std::ifstream is used, but necessary header was missing. Also `<cstring>` was missing for the strcmp(). While at it, remove superfluous headers. Also: simplify a boolean return (there was a else after return issue, and the whole expression could be written more concise and readable anyway). If there is a single statement in a block in a new line, add the necessary curly braces. Signed-off-by: Henner Zeller <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
I wouldn't spend any time on mpl as mpl2 will replace it. We are just working through some issues before #6047 |
maliberty
approved these changes
Dec 23, 2024
Contributor
Author
|
thanks. I was mostly looking at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std::ifstream is used, but necessary header was missing. Also
<cstring>was missing for the strcmp().While at it, remove superfluous headers.
Also: simplify a boolean return (there was a else after return issue, and the whole expression could be written more concise and readable anyway).
If there is a single statement in a block in a new line, add the necessary curly braces.