Skip to content

mpl: Fix random index generation with hack #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Feb 25, 2025
+37 −7
Merged

mpl: Fix random index generation with hack #6767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/mpl/src/SACoreSoftMacro.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,8 +738,15 @@ void SACoreSoftMacro::calNotchPenalty()

void SACoreSoftMacro::resizeOneCluster()
{
const int idx = static_cast<int>(
std::floor(distribution_(generator_) * pos_seq_.size()));
// TODO: See for explanation
// https://github.com/The-OpenROAD-Project/OpenROAD/pull/6649
float random_variable_0_1;
do {
random_variable_0_1 = distribution_(generator_);
} while (random_variable_0_1 >= 1.0);

const int idx
= static_cast<int>(std::floor(random_variable_0_1 * pos_seq_.size()));
macro_id_ = idx;
SoftMacro& src_macro = macros_[idx];
if (src_macro.isMacroCluster()) {
Expand Down
22 changes: 19 additions & 3 deletions src/mpl/src/SimulatedAnnealingCore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,11 +626,27 @@ void SimulatedAnnealingCore<T>::exchangeMacros()
template <class T>
void SimulatedAnnealingCore<T>::generateRandomIndices(int& index1, int& index2)
{
index1 = (int) (std::floor(distribution_(generator_) * pos_seq_.size()));
index2 = (int) (std::floor(distribution_(generator_) * pos_seq_.size()));
// TODO: See for explanation.
// https://github.com/The-OpenROAD-Project/OpenROAD/pull/6649
// This code is ugly on purpose to incentivize merging the proper
// fix.
float random_variable_0_1_index1;
float random_variable_0_1_index2;
do {
random_variable_0_1_index1 = distribution_(generator_);
random_variable_0_1_index2 = distribution_(generator_);
} while (random_variable_0_1_index1 >= 1.0
|| random_variable_0_1_index2 >= 1.0);

index1 = (int) (std::floor(random_variable_0_1_index1 * pos_seq_.size()));
index2 = (int) (std::floor(random_variable_0_1_index2 * pos_seq_.size()));

while (index1 == index2) {
index2 = (int) (std::floor(distribution_(generator_) * pos_seq_.size()));
do {
random_variable_0_1_index2 = distribution_(generator_);
} while (random_variable_0_1_index2 >= 1.0);

index2 = (int) (std::floor(random_variable_0_1_index2 * pos_seq_.size()));
}
}

Expand Down
11 changes: 9 additions & 2 deletions src/mpl/src/object.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,8 +1261,15 @@ void SoftMacro::resizeRandomly(
if (width_list_.empty()) {
return;
}
const int idx = static_cast<int>(
std::floor(distribution(generator) * width_list_.size()));
// TODO: See for explanation
// https://github.com/The-OpenROAD-Project/OpenROAD/pull/6649
float random_variable_0_1;
do {
random_variable_0_1 = distribution(generator);
} while (random_variable_0_1 >= 1.0);

const int idx
= static_cast<int>(std::floor(random_variable_0_1 * width_list_.size()));
const float min_width = width_list_[idx].first;
const float max_width = width_list_[idx].second;
width_ = min_width + distribution(generator) * (max_width - min_width);
Expand Down