Skip to content

bazel: configure timeout times in .bazelrc #7085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Apr 9, 2025
Merged

bazel: configure timeout times in .bazelrc #7085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ common --enable_workspace # explicitly currently still needing this
# versions found in dependency graph.
common --check_direct_dependencies=off

# Test timeouts for various levels.
test --test_timeout=300,1800,1800,9600
Copy link
Member

@maliberty maliberty Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not match the removed --test_timeout=3600,3600,3600,3600

Copy link
Contributor Author

@hzeller hzeller Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. Let's say it is refined.

Copy link
Member

@maliberty maliberty Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the goal was the avoid timeouts without having to classify the test cases now. This seems to open the door the previous problems.

Copy link
Contributor Author

@hzeller hzeller Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have essentially a bimodal set of tests. The ones that are small, and the other ones. The small ones typically run in < 1min (and mostly < 1 sec actually), so I gave them 5min.

The big flow tests are large and actually can take longer than 1h, so I gave them a good chunk.

The other test kinds are not used, so I gave them something in the middle.


# bazel 7 is somewhat forgiving for glob patterns that don't
# match, but bazel 8 will be strict. So start now.
common --incompatible_disallow_empty_glob
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/github-actions-bazel-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,13 @@ jobs:

- name: Build
run: |
# Timeout is not per test, but for the entire CI job. Running
# times are tracked in ORFS tests over time.
bazel test \
-c opt \
--keep_going \
--show_timestamps \
--test_output=errors \
--curses=no \
--force_pic \
--test_timeout=3600,3600,3600,3600 \
...

- name: Smoke test
Expand Down