Skip to content

grt: support for clock nets with NDR in GRT#8100

Merged
eder-matheus merged 48 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:cts-ndr-arg-tests
Aug 28, 2025
Merged

grt: support for clock nets with NDR in GRT#8100
eder-matheus merged 48 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:cts-ndr-arg-tests

Conversation

@openroad-ci
Copy link
Collaborator

@openroad-ci openroad-ci commented Aug 22, 2025

Closes #8098

jfgava added 30 commits June 29, 2025 19:05
@jfgava
cts: implementing functions to apply NDR to specific clk tree levels
2be5ba1 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
cts: update sta
1cf2844 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
cts: enable ndr to all non-leaf clk nets
a823cb3 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
Merge branch 'master' of github.com:The-OpenROAD-Project-private/Open…
563d3a0 
…ROAD into cts-ndr-arg-tests
@jfgava
cts: enable partial NDR for testing
547ca84 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
update sta commit
b9fb753 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: rounding down NDR track consumption and debug
f9e33e7 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
cts: new test applying NDR to all clk nets except leafs
b03d0bf 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: give priority to ndr nets to avoid layer assignment issues
3f2c79c 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: update 2D usage with layer edge cost to avoid overflows mismatch…
c1b0d60 
… against 3D

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: undo changes to NDR cost rounding
71d4eb2 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: congestion debug and some implementation to solve NDR issues
a276528 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
cts: enable NDR for half clk tree. grt: some debugging and minor chan…
2e8c057 
…ges.

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: get 2D edge cost considering 3D sufficient capacity for NDR nets
b01bcdd 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: wrong checking
4e7606c 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
Merge branch 'master' of github.com:The-OpenROAD-Project-private/Open…
83095d8 
…ROAD into cts-ndr-arg-tests

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: submodules update
5b316ef 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
Merge branch 'master' of github.com:The-OpenROAD-Project-private/Open…
316edb8 
…ROAD into cts-ndr-arg-tests
@jfgava
grt: new implementation of updateUsage considering NDR
76733fc 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: merge updates
0c09f7f 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: increased maze3D route len treshold and removed check2DEdgesUsag…
5486f19 
…e from getOverflow2D

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
cts: apply partial NDR
030e7da 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: fix wrong call to net->getLayerEdgeCost. Cleaning code...
ad96e8e 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: fixing gf12 corner cases and wrong resource usage
bbeecb4 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
cts: enable level0-NDR
1d7639e 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: comment some reports for debug
dd10ef7 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: simpler implementation for multi-NDR 3D capacity check during 2D
bc96db8 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: fixed layer assignment not checking the correct edge cost
386f084 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: compute NDR edge cost only for the net layer range
268b1ac 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: code cleaning and refactoring
5facb6e 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
jfgava added 2 commits August 22, 2025 17:30
@jfgava
grt: removing unused code and cleaning
601551e 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: cleaning code
b83ff32 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
github-actions[bot]
github-actions bot reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/grt/src/fastroute/src/RipUp.cpp Outdated
const auto [ymin, ymax] = std::minmax(y1, y2);
const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

  const int edgeCost = net->getEdgeCost();
                       ^

src/grt/src/fastroute/src/RipUp.cpp Outdated
const auto [ymin, ymax] = std::minmax(y1, y2);

FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

  const int edgeCost = net->getEdgeCost();
                       ^

src/grt/src/fastroute/src/RipUp.cpp Outdated
}
if (needRipup) {
const int edgeCost = nets_[netID]->getEdgeCost();
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

    const int edgeCost = net->getEdgeCost();
                         ^

src/grt/src/fastroute/src/RipUp.cpp Outdated
{
const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

  const int edgeCost = net->getEdgeCost();
                       ^

src/grt/src/fastroute/src/graph2d.cpp Outdated
// Checks if there is enough NDR capacity for a given net.
bool Graph2D::hasNDRCapacity(FrNet* net, int x, int y, EdgeDirection direction)
{
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

  const int edgeCost = net->getEdgeCost();
                       ^

src/grt/src/fastroute/src/route.cpp Outdated

const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

  const int edgeCost = net->getEdgeCost();
                       ^

src/grt/src/fastroute/src/route.cpp Outdated

const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

  const int edgeCost = net->getEdgeCost();
                       ^

src/grt/src/fastroute/src/utility.cpp Outdated

const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

    const int edgeCost = net->getEdgeCost();
                         ^

src/grt/src/fastroute/src/utility.cpp Outdated
const int numEdges = sttrees_[netID].num_edges();
const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

      const int edgeCost = net->getEdgeCost();
                           ^

src/grt/src/fastroute/src/utility.cpp Outdated
const int numEdges = sttrees_[netID].num_edges();
const int edgeCost = nets_[netID]->getEdgeCost();
FrNet* net = nets_[netID];
const int edgeCost = net->getEdgeCost();
Copy link
Contributor

@github-actions github-actions bot Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'signed char' to 'const int' conversion; consider casting to 'unsigned char' first. [bugprone-signed-char-misuse]

      const int edgeCost = net->getEdgeCost();
                           ^

jfgava added 2 commits August 22, 2025 18:35
@jfgava
grt: fix clang-tidy signed char to const int conversion
995b629 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: fix wrong used_ggrid insertion
96c6336 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2025

clang-tidy review says "All clean, LGTM! 👍"

jfgava added 4 commits August 23, 2025 12:44
@jfgava
grt: initialize structures outside fastroute to avoid incorrect behav…
5d4b3da 
…ior during incremental run

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: increase mazeRoute3D routelen threshold to enhance routing with …
839a8c1 
…NDR nets

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: update regression tests
9745145 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: fix code format
2a2adcf 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2025

clang-tidy review says "All clean, LGTM! 👍"

jfgava added 3 commits August 27, 2025 00:15
@jfgava
Merge commit 'e561a140c1958bf883e008151f31ed50c318adc0' into cts-ndr-…
1b00df4 
…arg-tests
@jfgava
grt: fix debug overflow coordinates
e50afba 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava
grt: clear list of NDR nets after repair antenna
18ac622 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

maliberty commented Aug 27, 2025

@eder-matheus I'll leave this to you to review and approve

@maliberty maliberty removed their request for review August 27, 2025 17:34
jfgava added 2 commits August 27, 2025 18:05
@jfgava
Merge commit '9690c31c6fa82f7bd5967f1b5ba8ec11c82f3d03' into cts-ndr-…
834d531 
…arg-tests
@jfgava
Merge branch 'master' of github.com:The-OpenROAD-Project-private/Open…
0cd6101 
…ROAD into cts-ndr-arg-tests

Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

clang-tidy review says "All clean, LGTM! 👍"

eder-matheus
eder-matheus requested changes Aug 28, 2025
View reviewed changes
@jfgava
grt: cleaning code, refactoring, adding comments
5a89c86 
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

clang-tidy review says "All clean, LGTM! 👍"

eder-matheus
eder-matheus approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@eder-matheus eder-matheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll wait to merge until we have a complete secure-ci run.

@eder-matheus eder-matheus enabled auto-merge August 28, 2025 17:34
@eder-matheus eder-matheus merged commit 8244762 into The-OpenROAD-Project:master Aug 28, 2025
11 checks passed
@openroad-ci openroad-ci deleted the cts-ndr-arg-tests branch August 28, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@eder-matheus eder-matheus eder-matheus approved these changes

+1 more reviewer

@jfgava jfgava jfgava left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jfgava jfgava

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grt: enabling clock nets with NDR in GRT

4 participants

@openroad-ci @maliberty @jfgava @eder-matheus