mpl: rename sa method used just in shaping to avoid confusion#8125
Merged
eder-matheus merged 1 commit intoThe-OpenROAD-Project:masterfrom Aug 26, 2025
Merged
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
eder-matheus
approved these changes
Aug 26, 2025
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strategy in shaping is to generate different tilings for clusters with macros by annealing with different outlines (starting from the original and making it smaller) and, at the end, checking to see if they fit in the actual outline. However, I don't think that the concept of "validity" applies for this situation as, from the annealer perspective, the outline is an external parameter.
With these changes, the polymorphism needed for the partial macro placement support will get much less confusing (Soft SA validity will rely on more than just the outline fitting check).