Use "" instead of <> for vendored boost dependency headers.#8128
Conversation
|
@hzeller will this work when we import into google3 |
Boost is a vendored resources (in bazel but also in the way it is installed with etc/DependencyInstaller.sh). Thus, use the quote instead of angle-bracket includes for them. Signed-off-by: Henner Zeller <hzeller@google.com>
hzeller
force-pushed
the
feature-20250827-vendored-boost
branch
from
21e11bd to
7a4c936
Compare
|
@QuantamHD : don't know yet, but I'll have a look once it is in here, maybe it requires some copybara updates. Edit: confirmed it will work. |
|
clang-tidy review says "All clean, LGTM! 👍" |
| deps = [ | ||
| "//src/sta:opensta_lib", | ||
| "@boost.container_hash", | ||
| "@boost.unordered", | ||
| ], |
There was a problem hiding this comment.
I'm curious why this change would require changes to the deps. Were we getting these by some non-hermetic means before?
There was a problem hiding this comment.
Simple: In the course of fixing the headers I discovered that these deps were missing
There was a problem hiding this comment.
Wouldn't the code fail to compile without them then?
There was a problem hiding this comment.
maybe there was boost installed on the system, so it was accidentally compiling.
Because the include was with angle-brackets and thus looked as system header, the blaze would also not necessarily do a layering check.
There was a problem hiding this comment.
Can we avoid having it look at anything outside the sandbox? This seems like a hole in the hermetic nature.
maliberty
merged commit e79e225
into
The-OpenROAD-Project:master
Like The-OpenROAD-Project#8128, but thse went under the radar due to unusual file suffices. Signed-off-by: Henner Zeller <h.zeller@acm.org>
3 participants
Boost is a vendored resources (in bazel but also in the way it is installed with etc/DependencyInstaller.sh).
Thus, use the quote instead of angle-bracket includes for them.