Skip to content

test: OPENROAD_HIERARCHICAL=1 on mock-array power test#8150

Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
Pinata-Consulting:mock-array-power-test
Aug 29, 2025
Merged

test: OPENROAD_HIERARCHICAL=1 on mock-array power test#8150
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
Pinata-Consulting:mock-array-power-test

Conversation

@oharboe
Copy link
Collaborator

@oharboe oharboe commented Aug 29, 2025

No description provided.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
Copy link
Collaborator Author

oharboe commented Aug 29, 2025

@jhkim-pii @maliberty Should reproduce #8142

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Collaborator Author

oharboe commented Aug 29, 2025

Lots of warnings to investigate...

[2025-08-29T00:49:56.357Z] (00:49:53) INFO: From [Verilator] Compiling @@//test/orfs/mock-array:array_verilator:
[2025-08-29T00:49:56.357Z] stderr (/root/.cache/bazel/_bazel_root/e60b8661e582bb05b4aaf2262af88401/execroot/_main/bazel-out/_tmp/actions/stderr-17960) 3050604 exceeds maximum size of --experimental_ui_max_stdouterr_bytes=1048576 bytes; skipping

Investigate which warnings to disable and whether to switch to -Werror:

verilator_cc_library(
name = "array_verilator",
copts = [
# Don't care about warnings from Verilator generated C++
"-Wno-unused-variable",
],
module = ":array",
module_top = "MockArray",
trace = True,
vopts = [
"--timescale 1ps/1ps",
"-Wall",
"-Wno-DECLFILENAME",
"-Wno-UNUSEDSIGNAL",
"-Wno-PINMISSING",
"--trace-underscore",
],
)

@oharboe oharboe changed the title test: OPENROAD_HIERARCHICAL=1 on mock-array power test [DO NOT REVIEW] test: OPENROAD_HIERARCHICAL=1 on mock-array power test Aug 29, 2025
@oharboe oharboe marked this pull request as draft August 29, 2025 01:34
@oharboe
Copy link
Collaborator Author

oharboe commented Aug 29, 2025

@jhkim-pii FYI I'll revisit/reopen after some more -hier fixes land.

@oharboe oharboe closed this Aug 29, 2025
@oharboe oharboe reopened this Aug 29, 2025
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

…g noise

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe changed the title [DO NOT REVIEW] test: OPENROAD_HIERARCHICAL=1 on mock-array power test test: OPENROAD_HIERARCHICAL=1 on mock-array power test Aug 29, 2025
@oharboe oharboe marked this pull request as ready for review August 29, 2025 05:47
@oharboe
Copy link
Collaborator Author

oharboe commented Aug 29, 2025

@maliberty @jhkim-pii Verilator didn't find anything more than is already reported in issues. Good to go.

@oharboe oharboe requested a review from maliberty August 29, 2025 05:48
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Collaborator Author

oharboe commented Aug 29, 2025

@maliberty Unrelated CI error:

Found unhandled java.io.IOException exception:
Failed to run image 'openroad/ubuntu22.04-dev:895789'. Error: Unable to find image 'openroad/ubuntu22.04-dev:895789' locally
895789: Pulling from openroad/ubuntu22.04-dev
3

@maliberty maliberty enabled auto-merge August 29, 2025 14:06
@maliberty maliberty merged commit 4f2b2d2 into The-OpenROAD-Project:master Aug 29, 2025
11 checks passed
@oharboe oharboe deleted the mock-array-power-test branch August 29, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants