Skip to content

gpl: Allow for MBFF tray identification on flops that have scan, preset, and clear pins.#8222

Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
hongted:mbff
Oct 25, 2025
Merged

gpl: Allow for MBFF tray identification on flops that have scan, preset, and clear pins.#8222
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
hongted:mbff

Conversation

@hongted
Copy link
Contributor

@hongted hongted commented Sep 3, 2025

No description provided.

@hongted hongted changed the title Allow for MBFF tray identification on flops that have scan, preset, and clear pins. gpl: Allow for MBFF tray identification on flops that have scan, preset, and clear pins. Sep 3, 2025
@hongted hongted force-pushed the mbff branch 3 times, most recently from 4844a82 to e5c4e4c Compare September 3, 2025 18:26
@hongted hongted force-pushed the mbff branch 2 times, most recently from 6205c67 to 18f2521 Compare September 5, 2025 21:12
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@hongted hongted force-pushed the mbff branch 2 times, most recently from 5830a70 to 98b52cc Compare September 6, 2025 00:30
@maliberty
Copy link
Member

some conflicts to resolve

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@hongted hongted force-pushed the mbff branch 2 times, most recently from a40386d to e1532f9 Compare September 10, 2025 22:59
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hongted
Copy link
Contributor Author

hongted commented Sep 11, 2025

some conflicts to resolve

Resolved. Rest will be fixed once I rebase onto the parent PR.

@hongted hongted force-pushed the mbff branch 2 times, most recently from 2e6fc96 to cb84969 Compare September 11, 2025 23:15
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@hongted hongted force-pushed the mbff branch 5 times, most recently from dd30acc to b9e075e Compare October 22, 2025 22:26
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

…et, and clear ports.

Signed-off-by: Ted Hong <tedhong@google.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

Merged master so I could see the changes here without the noise of the gui changes that are already merged.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

class MBFFTestFixture : public tst::Fixture
{
protected:
void SetUp() override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought is that we would create one fixture per tool that would handle all the dependency setup so that all the tests could share it. Since there is just one test for gpl now this is ok but we should plan to split it out in the future.

@maliberty maliberty enabled auto-merge October 25, 2025 14:22
@maliberty maliberty merged commit ee97594 into The-OpenROAD-Project:master Oct 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments