Get location using make_result_file#8304
Get location using make_result_file#8304hzeller wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
make_result_file#8304Conversation
|
CC: @oharboe |
Fixes The-OpenROAD-Project#8278 Signed-off-by: Henner Zeller <h.zeller@acm.org>
5777091 to
cbc460a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
| puts "Corner: ss" | ||
| report_layer_rc -corner ss | ||
|
|
||
| estimate_parasitics -placement -spef_file results/make_parasitics6.spef |
There was a problem hiding this comment.
I don't understand what it is in this script that is supposed to write out the result files...
This should have done the trick, no?
diff --git a/src/est/test/make_parasitics6.tcl b/src/est/test/make_parasitics6.tcl
index 7400f6ac7e..38b56052f1 100644
--- a/src/est/test/make_parasitics6.tcl
+++ b/src/est/test/make_parasitics6.tcl
@@ -28,10 +28,12 @@ report_layer_rc -corner ff
puts "Corner: ss"
report_layer_rc -corner ss
-estimate_parasitics -placement -spef_file results/make_parasitics6.spef
+set spef_file [make_result_file make_parasitics6.spef]
+estimate_parasitics -placement -spef_file $spef_file
report_net r1/Q -corner ff
report_net r1/Q -corner ss
-diff_file make_parasitics6_ff.spefok results/make_parasitics6_ff.spef
-diff_file make_parasitics6_ss.spefok results/make_parasitics6_ss.spef
+set spef_file_folder [file dirname $spef_file]
+diff_file make_parasitics6_ff.spefok $spef_file_folder/make_parasitics6_ff.spef
+diff_file make_parasitics6_ss.spefok $spef_file_folder/make_parasitics6_ss.spefError:
Error: make_parasitics6.tcl, 38 couldn't open "/home/oyvind/.cache/bazel/_bazel_oyvind/896cc02f64446168f604c13ad7b60f8b/sandbox/processwrapper-sandbox/88/execroot/_main/_tmp/c411b99b5b0f9e0b9147e11c04e0388f/results/make_parasitics6_ff.spef": no such file or directory
|
I suspect you need to update the diff_file lines to match |
|
To reproduce, how can I run a particular test in cmake ? Also, how can I make it not run tests sequentially but in parallel ? (it works in bazel, so that is why I stopped there). |
|
The regression script is just a wrapper on ctest so all of its flags apply. |
|
It should not work in bazel either so that makes me suspicious. |
|
Ok, so it works now in bazel but not in cmake anymore... |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
|
||
| diff_file make_parasitics6_ff.spefok results/make_parasitics6_ff.spef | ||
| diff_file make_parasitics6_ss.spefok results/make_parasitics6_ss.spef | ||
| diff_file make_parasitics6_ff.spefok results/make_parasitics6-tcl_ff.spef |
There was a problem hiding this comment.
ah, estimate_parasitics writes out all the corners. I seem to recall.
|
how about #8315? |
|
Abandoning in favor of #8315 |

Fixes #8278