Skip to content

Comments

Get location using make_result_file#8304

Closed
hzeller wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20250911-fix-8278
Closed

Get location using make_result_file#8304
hzeller wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20250911-fix-8278

Conversation

@hzeller
Copy link
Collaborator

@hzeller hzeller commented Sep 11, 2025

Fixes #8278

@hzeller
Copy link
Collaborator Author

hzeller commented Sep 11, 2025

CC: @oharboe

Fixes The-OpenROAD-Project#8278

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller force-pushed the feature-20250911-fix-8278 branch from 5777091 to cbc460a Compare September 11, 2025 14:03
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

puts "Corner: ss"
report_layer_rc -corner ss

estimate_parasitics -placement -spef_file results/make_parasitics6.spef
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what it is in this script that is supposed to write out the result files...

This should have done the trick, no?

diff --git a/src/est/test/make_parasitics6.tcl b/src/est/test/make_parasitics6.tcl
index 7400f6ac7e..38b56052f1 100644
--- a/src/est/test/make_parasitics6.tcl
+++ b/src/est/test/make_parasitics6.tcl
@@ -28,10 +28,12 @@ report_layer_rc -corner ff
 puts "Corner: ss"
 report_layer_rc -corner ss
 
-estimate_parasitics -placement -spef_file results/make_parasitics6.spef
+set spef_file [make_result_file make_parasitics6.spef]
+estimate_parasitics -placement -spef_file $spef_file
 
 report_net r1/Q -corner ff
 report_net r1/Q -corner ss
 
-diff_file make_parasitics6_ff.spefok results/make_parasitics6_ff.spef
-diff_file make_parasitics6_ss.spefok results/make_parasitics6_ss.spef
+set spef_file_folder [file dirname $spef_file]
+diff_file make_parasitics6_ff.spefok $spef_file_folder/make_parasitics6_ff.spef
+diff_file make_parasitics6_ss.spefok $spef_file_folder/make_parasitics6_ss.spef

Error:

Error: make_parasitics6.tcl, 38 couldn't open "/home/oyvind/.cache/bazel/_bazel_oyvind/896cc02f64446168f604c13ad7b60f8b/sandbox/processwrapper-sandbox/88/execroot/_main/_tmp/c411b99b5b0f9e0b9147e11c04e0388f/results/make_parasitics6_ff.spef": no such file or directory

@maliberty
Copy link
Member

I suspect you need to update the diff_file lines to match

@maliberty
Copy link
Member

Yep
image

@hzeller
Copy link
Collaborator Author

hzeller commented Sep 11, 2025

To reproduce, how can I run a particular test in cmake ? Also, how can I make it not run tests sequentially but in parallel ?

(it works in bazel, so that is why I stopped there).

@maliberty
Copy link
Member

The regression script is just a wrapper on ctest so all of its flags apply. -R to match tests by regex. -j for threads

@maliberty
Copy link
Member

It should not work in bazel either so that makes me suspicious.

@hzeller hzeller marked this pull request as draft September 11, 2025 17:07
@hzeller
Copy link
Collaborator Author

hzeller commented Sep 11, 2025

Ok, so it works now in bazel but not in cmake anymore...
I don't know how this is set up, so setting this to draft and hand it over to someone who knows what is going on; maybe this can serve as a starting point.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"


diff_file make_parasitics6_ff.spefok results/make_parasitics6_ff.spef
diff_file make_parasitics6_ss.spefok results/make_parasitics6_ss.spef
diff_file make_parasitics6_ff.spefok results/make_parasitics6-tcl_ff.spef
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, estimate_parasitics writes out all the corners. I seem to recall.

@oharboe
Copy link
Collaborator

oharboe commented Sep 12, 2025

how about #8315?

@hzeller
Copy link
Collaborator Author

hzeller commented Sep 12, 2025

Abandoning in favor of #8315

@hzeller hzeller closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bazel: //src/est/test:make_parasitics6-tcl test currently failng

3 participants